From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DED5321BBC423 for ; Thu, 22 Jun 2017 20:21:50 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jun 2017 20:23:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,376,1493708400"; d="scan'208";a="277676986" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 22 Jun 2017 20:23:16 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Jun 2017 20:23:16 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Fri, 23 Jun 2017 11:23:11 +0800 From: "Gao, Liming" To: Supreeth Venkatesh , "edk2-devel@lists.01.org" CC: "leif.lindholm@linaro.org" , "Kinney, Michael D" , "achin.gupta@arm.com" , "felixp@ami.com" , "jbrasen@qti.qualcomm.com" , "jonathan.zhang@cavium.com" , "Yao, Jiewen" Thread-Topic: [PATCH v3 01/10] BaseTools: Tools change to support PI v1.5 Specification. Thread-Index: AQHS65F6V7kFbKUNf0mKmprzIukN7KIxxYWA Date: Fri, 23 Jun 2017 03:23:11 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D74DAEA@shsmsx102.ccr.corp.intel.com> References: <1498161266-18877-1-git-send-email-supreeth.venkatesh@arm.com> <1498161266-18877-2-git-send-email-supreeth.venkatesh@arm.com> In-Reply-To: <1498161266-18877-2-git-send-email-supreeth.venkatesh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 01/10] BaseTools: Tools change to support PI v1.5 Specification. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 03:21:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Supreeth: I just realize MM_STANDALONE and MM_CORE_STANDALONE are new feature. They= have no compatibility issue. We can directly define them with MM prefix in= stead of SMM prefix. So, for new added FV file type MM_STANDALONE and MM_CO= RE_STANDALONE, I prefer to use the same definition with PI spec. For new mo= dule type MM_STANDALONE and MM_CORE_STANDALONE, I suggest to update BaseToo= ls to support them only.=20 For the existing SMM_CORE, DXE_SMM_DRIVER, they will still be kept for co= mpatibility.=20 Thanks Liming >-----Original Message----- >From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com] >Sent: Friday, June 23, 2017 3:54 AM >To: edk2-devel@lists.01.org >Cc: leif.lindholm@linaro.org; Kinney, Michael D >; Gao, Liming ; >achin.gupta@arm.com; supreeth.venkatesh@arm.com; felixp@ami.com; >jbrasen@qti.qualcomm.com; jonathan.zhang@cavium.com; Yao, Jiewen > >Subject: [PATCH v3 01/10] BaseTools: Tools change to support PI v1.5 >Specification. > >PI specification v1.5 defines new firmware volume file types. > >This patch adds the new file type EFI_FV_FILETYPE_SMM_STANDALONE and >EFI_FV_FILETYPE_SMM_CORE_STANDALONE in GenFfs tool. >*_SMM_* regex instead of *_MM_* is used to preserve >backwards compatibility. > >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Jiewen Yao >Signed-off-by: Supreeth Venkatesh >--- > BaseTools/Source/C/GenFfs/GenFfs.c | 8 ++++++-- > BaseTools/Source/C/Include/Common/PiFirmwareFile.h | 2 ++ > 2 files changed, 8 insertions(+), 2 deletions(-) > >diff --git a/BaseTools/Source/C/GenFfs/GenFfs.c >b/BaseTools/Source/C/GenFfs/GenFfs.c >index c5d657b..c394b8b 100644 >--- a/BaseTools/Source/C/GenFfs/GenFfs.c >+++ b/BaseTools/Source/C/GenFfs/GenFfs.c >@@ -43,8 +43,10 @@ STATIC CHAR8 *mFfsFileType[] =3D { > "EFI_FV_FILETYPE_SMM", // 0x0A > "EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE",// 0x0B > "EFI_FV_FILETYPE_COMBINED_SMM_DXE", // 0x0C >- "EFI_FV_FILETYPE_SMM_CORE" // 0x0D >- }; >+ "EFI_FV_FILETYPE_SMM_CORE", // 0x0D >+ "EFI_FV_FILETYPE_SMM_STANDALONE", // 0x0E >+ "EFI_FV_FILETYPE_SMM_CORE_STANDALONE" // 0x0F >+}; > > STATIC CHAR8 *mAlignName[] =3D { > "1", "2", "4", "8", "16", "32", "64", "128", "256", "512", >@@ -130,6 +132,8 @@ Returns: > EFI_FV_FILETYPE_DRIVER, EFI_FV_FILETYPE_APPLICATI= ON,\n\ > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER,\n\ > EFI_FV_FILETYPE_SMM, EFI_FV_FILETYPE_SMM_CORE,\n\ >+ EFI_FV_FILETYPE_SMM_STANDALONE,\n\ >+ EFI_FV_FILETYPE_SMM_CORE_STANDALONE,\n\ > EFI_FV_FILETYPE_COMBINED_SMM_DXE, \n\ > EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE.\n"); > fprintf (stdout, " -g FileGuid, --fileguid FileGuid\n\ >diff --git a/BaseTools/Source/C/Include/Common/PiFirmwareFile.h >b/BaseTools/Source/C/Include/Common/PiFirmwareFile.h >index 2984860..8b40ec2 100644 >--- a/BaseTools/Source/C/Include/Common/PiFirmwareFile.h >+++ b/BaseTools/Source/C/Include/Common/PiFirmwareFile.h >@@ -52,6 +52,8 @@ typedef UINT8 EFI_FFS_FILE_STATE; > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > #define EFI_FV_FILETYPE_SMM_CORE 0x0D >+#define EFI_FV_FILETYPE_SMM_STANDALONE 0x0E >+#define EFI_FV_FILETYPE_SMM_CORE_STANDALONE 0x0F > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 >-- >2.7.4