From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <liming.gao@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 61CCA21BBC41E
 for <edk2-devel@lists.01.org>; Thu, 22 Jun 2017 23:34:20 -0700 (PDT)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga104.jf.intel.com with ESMTP; 22 Jun 2017 23:35:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,376,1493708400"; d="scan'208";a="277726080"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by fmsmga004.fm.intel.com with ESMTP; 22 Jun 2017 23:35:45 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 22 Jun 2017 23:35:45 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 22 Jun 2017 23:35:45 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002;
 Fri, 23 Jun 2017 14:35:43 +0800
From: "Gao, Liming" <liming.gao@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>, "edk2-devel@lists.01.org"
 <edk2-devel@lists.01.org>
CC: "Justen, Jordan L" <jordan.l.justen@intel.com>
Thread-Topic: [PATCH 0/2] Some refines to BaseTools/PatchCheck.py
Thread-Index: AQHS4CvT4rRXjNWvjku2lH8qjLEZi6IyFXow
Date: Fri, 23 Jun 2017 06:35:42 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D74DD23@shsmsx102.ccr.corp.intel.com>
References: <20170608074924.12900-1-hao.a.wu@intel.com>
In-Reply-To: <20170608074924.12900-1-hao.a.wu@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [PATCH 0/2] Some refines to BaseTools/PatchCheck.py
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Jun 2017 06:34:20 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Wu, Hao A
>Sent: Thursday, June 08, 2017 3:49 PM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Justen, Jordan L <jordan.l.justen@intel.com>
>Subject: [PATCH 0/2] Some refines to BaseTools/PatchCheck.py
>
>The following two refinements are made to PatchCheck.py:
>a. Resolves misreport of 'Patch format error: diff found after end of
>   patch', when a patch file contains a binary file change and any other
>   changes after the binary change.
>
>b. Adds detection of adding new binary files in a patch file or in a
>   commit.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Jordan Justen <jordan.l.justen@intel.com>
>
>Hao Wu (2):
>  BaseTools/PatchCheck.py: Fix misreport for binary changes in patch
>  BaseTools/PatchCheck.py: Add warning info for new binary files
>
> BaseTools/Scripts/PatchCheck.py | 40 ++++++++++++++++++++++++---------
>-------
> 1 file changed, 24 insertions(+), 16 deletions(-)
>
>--
>2.12.0.windows.1