From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B681D21BBC422 for ; Thu, 22 Jun 2017 23:36:18 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 22 Jun 2017 23:37:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,376,1493708400"; d="scan'208";a="277726486" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 22 Jun 2017 23:37:44 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Jun 2017 23:37:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Jun 2017 23:37:43 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Fri, 23 Jun 2017 14:37:42 +0800 From: "Gao, Liming" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [PATCH] MdePkg/Cper.h: Update Firmware Error Record per UEFI 2.7 Thread-Index: AQHS5XOLoTVAoYVcsUGtPzOH7sBI5KIyC4OA Date: Fri, 23 Jun 2017 06:37:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D74DD42@shsmsx102.ccr.corp.intel.com> References: <20170615010538.12616-1-hao.a.wu@intel.com> In-Reply-To: <20170615010538.12616-1-hao.a.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/Cper.h: Update Firmware Error Record per UEFI 2.7 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 06:36:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Wu, Hao A >Sent: Thursday, June 15, 2017 9:06 AM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Kinney, Michael D >; Gao, Liming >Subject: [PATCH] MdePkg/Cper.h: Update Firmware Error Record per UEFI 2.7 > >This commit updates the Firmware Error Record related definitions >according to UEFI 2.7 spec Section N.2.10 Table 281: > >a. Adds definitions for 2 Firmware Error Record types >b. Update the structure EFI_FIRMWARE_ERROR_DATA > >Cc: Michael D Kinney >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Hao Wu >--- > MdePkg/Include/Guid/Cper.h | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > >diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h >index 88e3a5874f..5ddd4c715e 100644 >--- a/MdePkg/Include/Guid/Cper.h >+++ b/MdePkg/Include/Guid/Cper.h >@@ -1,7 +1,7 @@ > /** @file > GUIDs and definitions used for Common Platform Error Record. > >- Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.
>+ Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the B= SD >License >@@ -12,7 +12,7 @@ > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER >EXPRESS OR IMPLIED. > > @par Revision Reference: >- GUIDs defined in UEFI 2.6 Specification. >+ GUIDs defined in UEFI 2.7 Specification. > > **/ > >@@ -1088,16 +1088,21 @@ typedef struct { > > /// > /// Identifies the type of firmware error record >-/// >+///@{ > #define EFI_FIRMWARE_ERROR_TYPE_IPF_SAL 0x00 >+#define EFI_FIRMWARE_ERROR_TYPE_SOC_TYPE1 0x01 >+#define EFI_FIRMWARE_ERROR_TYPE_SOC_TYPE2 0x02 >+///@} > > /// > /// Firmware Error Record Section > /// > typedef struct { > UINT8 ErrorType; >- UINT8 Resv1[7]; >+ UINT8 Revision; >+ UINT8 Resv1[6]; > UINT64 RecordId; >+ EFI_GUID RecordIdGuid; > } EFI_FIRMWARE_ERROR_DATA; > > /// >-- >2.12.0.windows.1