From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: add some comment for .PrebuildEnv file's usage
Date: Wed, 26 Jul 2017 00:52:39 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D75A68E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1500962280-24272-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, July 25, 2017 1:58 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: add some comment for .PrebuildEnv file's usage
>
>This patch add some comments to explain why we use .PrebuildEnv file to
>save environment variable settings set by the prebuild script.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index f7634fa..4d05ee2 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -1027,10 +1027,15 @@ class Build():
>
> def LaunchPrebuild(self):
> if self.Prebuild:
> EdkLogger.info("\n- Prebuild Start -\n")
> self.LaunchPrebuildFlag = True
>+ #
>+ # The purpose of .PrebuildEnv file is capture environment variable
>settings set by the prebuild script
>+ # and preserve them for the rest of the main build step, because the
>child process environment will
>+ # evaporate as soon as it exits, we cannot get it in build step.
>+ #
> PrebuildEnvFile =
>os.path.join(GlobalData.gConfDirectory,'.cache','.PrebuildEnv')
> if os.path.isfile(PrebuildEnvFile):
> os.remove(PrebuildEnvFile)
> if os.path.isfile(self.PlatformBuildPath):
> os.remove(self.PlatformBuildPath)
>--
>2.6.1.windows.1
prev parent reply other threads:[~2017-07-26 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 5:58 [Patch] BaseTools: add some comment for .PrebuildEnv file's usage Yonghong Zhu
2017-07-26 0:52 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D75A68E@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox