From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BA8082095DBB4 for ; Tue, 25 Jul 2017 17:53:16 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2017 17:55:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,413,1496127600"; d="scan'208";a="1199340675" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 25 Jul 2017 17:55:15 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Jul 2017 17:52:42 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Jul 2017 17:52:41 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Wed, 26 Jul 2017 08:52:40 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: add some comment for .PrebuildEnv file's usage Thread-Index: AQHTBQsGK7La7qoKKkGsEVXoxBMrCaJlSNyQ Date: Wed, 26 Jul 2017 00:52:39 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D75A68E@shsmsx102.ccr.corp.intel.com> References: <1500962280-24272-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1500962280-24272-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: add some comment for .PrebuildEnv file's usage X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 00:53:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Tuesday, July 25, 2017 1:58 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: add some comment for .PrebuildEnv file's usage > >This patch add some comments to explain why we use .PrebuildEnv file to >save environment variable settings set by the prebuild script. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/build.py | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index f7634fa..4d05ee2 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -1027,10 +1027,15 @@ class Build(): > > def LaunchPrebuild(self): > if self.Prebuild: > EdkLogger.info("\n- Prebuild Start -\n") > self.LaunchPrebuildFlag =3D True >+ # >+ # The purpose of .PrebuildEnv file is capture environment var= iable >settings set by the prebuild script >+ # and preserve them for the rest of the main build step, beca= use the >child process environment will >+ # evaporate as soon as it exits, we cannot get it in build st= ep. >+ # > PrebuildEnvFile =3D >os.path.join(GlobalData.gConfDirectory,'.cache','.PrebuildEnv') > if os.path.isfile(PrebuildEnvFile): > os.remove(PrebuildEnvFile) > if os.path.isfile(self.PlatformBuildPath): > os.remove(self.PlatformBuildPath) >-- >2.6.1.windows.1