From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the bug that warn() function with only 1 argument
Date: Wed, 26 Jul 2017 00:52:46 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D75A69B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1500961160-23872-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, July 25, 2017 1:39 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Fix the bug that warn() function with only 1
>argument
>
>In the definition, the warn() function takes at least 2 arguments.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 1e14fb4..f7634fa 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -888,11 +888,11 @@ class Build():
> ToolChainFamily = []
> ToolDefinition = self.ToolDef.ToolsDefTxtDatabase
> for Tool in self.ToolChainList:
> if TAB_TOD_DEFINES_FAMILY not in ToolDefinition or Tool not in
>ToolDefinition[TAB_TOD_DEFINES_FAMILY] \
> or not ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool]:
>- EdkLogger.warn("No tool chain family found in configuration for %s.
>Default to MSFT." % Tool)
>+ EdkLogger.warn("build", "No tool chain family found in configuration
>for %s. Default to MSFT." % Tool)
> ToolChainFamily.append("MSFT")
> else:
>
>ToolChainFamily.append(ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool])
> self.ToolChainFamily = ToolChainFamily
>
>--
>2.6.1.windows.1
prev parent reply other threads:[~2017-07-26 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 5:39 [Patch] BaseTools: Fix the bug that warn() function with only 1 argument Yonghong Zhu
2017-07-26 0:52 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D75A69B@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox