From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 22BC521D28FF4 for ; Tue, 25 Jul 2017 17:53:22 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2017 17:55:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,413,1496127600"; d="scan'208";a="1199340704" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 25 Jul 2017 17:55:20 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Jul 2017 17:52:49 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Jul 2017 17:52:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Wed, 26 Jul 2017 08:52:47 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Fix the bug that warn() function with only 1 argument Thread-Index: AQHTBQhqvlK1cjUklU6FhPImvrC+FqJlSOlQ Date: Wed, 26 Jul 2017 00:52:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D75A69B@shsmsx102.ccr.corp.intel.com> References: <1500961160-23872-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1500961160-23872-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix the bug that warn() function with only 1 argument X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 00:53:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Tuesday, July 25, 2017 1:39 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the bug that warn() function with only 1 >argument > >In the definition, the warn() function takes at least 2 arguments. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/build.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 1e14fb4..f7634fa 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -888,11 +888,11 @@ class Build(): > ToolChainFamily =3D [] > ToolDefinition =3D self.ToolDef.ToolsDefTxtDatabase > for Tool in self.ToolChainList: > if TAB_TOD_DEFINES_FAMILY not in ToolDefinition or Tool not i= n >ToolDefinition[TAB_TOD_DEFINES_FAMILY] \ > or not ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool]: >- EdkLogger.warn("No tool chain family found in configurati= on for %s. >Default to MSFT." % Tool) >+ EdkLogger.warn("build", "No tool chain family found in co= nfiguration >for %s. Default to MSFT." % Tool) > ToolChainFamily.append("MSFT") > else: > >ToolChainFamily.append(ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool]) > self.ToolChainFamily =3D ToolChainFamily > >-- >2.6.1.windows.1