* [Patch] BaseTools: Fix the bug that warn() function with only 1 argument
@ 2017-07-25 5:39 Yonghong Zhu
2017-07-26 0:52 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2017-07-25 5:39 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao
In the definition, the warn() function takes at least 2 arguments.
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/build/build.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 1e14fb4..f7634fa 100644
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -888,11 +888,11 @@ class Build():
ToolChainFamily = []
ToolDefinition = self.ToolDef.ToolsDefTxtDatabase
for Tool in self.ToolChainList:
if TAB_TOD_DEFINES_FAMILY not in ToolDefinition or Tool not in ToolDefinition[TAB_TOD_DEFINES_FAMILY] \
or not ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool]:
- EdkLogger.warn("No tool chain family found in configuration for %s. Default to MSFT." % Tool)
+ EdkLogger.warn("build", "No tool chain family found in configuration for %s. Default to MSFT." % Tool)
ToolChainFamily.append("MSFT")
else:
ToolChainFamily.append(ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool])
self.ToolChainFamily = ToolChainFamily
--
2.6.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Fix the bug that warn() function with only 1 argument
2017-07-25 5:39 [Patch] BaseTools: Fix the bug that warn() function with only 1 argument Yonghong Zhu
@ 2017-07-26 0:52 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2017-07-26 0:52 UTC (permalink / raw)
To: Zhu, Yonghong, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, July 25, 2017 1:39 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Fix the bug that warn() function with only 1
>argument
>
>In the definition, the warn() function takes at least 2 arguments.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 1e14fb4..f7634fa 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -888,11 +888,11 @@ class Build():
> ToolChainFamily = []
> ToolDefinition = self.ToolDef.ToolsDefTxtDatabase
> for Tool in self.ToolChainList:
> if TAB_TOD_DEFINES_FAMILY not in ToolDefinition or Tool not in
>ToolDefinition[TAB_TOD_DEFINES_FAMILY] \
> or not ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool]:
>- EdkLogger.warn("No tool chain family found in configuration for %s.
>Default to MSFT." % Tool)
>+ EdkLogger.warn("build", "No tool chain family found in configuration
>for %s. Default to MSFT." % Tool)
> ToolChainFamily.append("MSFT")
> else:
>
>ToolChainFamily.append(ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool])
> self.ToolChainFamily = ToolChainFamily
>
>--
>2.6.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-26 0:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-25 5:39 [Patch] BaseTools: Fix the bug that warn() function with only 1 argument Yonghong Zhu
2017-07-26 0:52 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox