public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify
Date: Wed, 26 Jul 2017 04:54:30 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D75A945@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170719091458.336268-1-ruiyu.ni@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Ni, Ruiyu
>Sent: Wednesday, July 19, 2017 5:15 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [PATCH] MdePkg/ResetNotification: Rename to
>UnregisterResetNotify
>
>UEFI Spec uses UnRegisterResetNotify in protocol structure
>definition but uses UnregisterResetNotify in the function
>prototype definition.
>
>By searching the entire spec, Unregister* is used for
>SIMPLE_TEXT_INPUT_EX_PROTOCOL.UnregisterKeyNotify(). So choose
>to use UnregisterResetNotify for consistency.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> MdePkg/Include/Protocol/ResetNotification.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/MdePkg/Include/Protocol/ResetNotification.h
>b/MdePkg/Include/Protocol/ResetNotification.h
>index ade0eee34a..f2834f9ee1 100644
>--- a/MdePkg/Include/Protocol/ResetNotification.h
>+++ b/MdePkg/Include/Protocol/ResetNotification.h
>@@ -76,7 +76,7 @@ EFI_STATUS
>
> typedef struct _EFI_RESET_NOTIFICATION_PROTOCOL {
>   EFI_REGISTER_RESET_NOTIFY   RegisterResetNotify;
>-  EFI_UNREGISTER_RESET_NOTIFY UnRegisterResetNotify;
>+  EFI_UNREGISTER_RESET_NOTIFY UnregisterResetNotify;
> } EFI_RESET_NOTIFICATION_PROTOCOL;
>
>
>--
>2.12.2.windows.2



      reply	other threads:[~2017-07-26  4:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19  9:14 [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify Ruiyu Ni
2017-07-26  4:54 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D75A945@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox