public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH] ShellPkg/ShellLib: Remove unused macros
Date: Thu, 27 Jul 2017 03:38:06 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D75C6B6@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170726093422.36684-1-ruiyu.ni@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Ni, Ruiyu
>Sent: Wednesday, July 26, 2017 5:34 PM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [PATCH] ShellPkg/ShellLib: Remove unused macros
>
>MAX_FILE_NAME_LEN and FIND_XXXXX_FILE_BUFFER_SIZE are not used
>by ShellLib so remove them.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> ShellPkg/Include/Library/ShellLib.h          | 5 +----
> ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 --
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/ShellPkg/Include/Library/ShellLib.h
>b/ShellPkg/Include/Library/ShellLib.h
>index 9b611d8016..268a767b70 100644
>--- a/ShellPkg/Include/Library/ShellLib.h
>+++ b/ShellPkg/Include/Library/ShellLib.h
>@@ -1,7 +1,7 @@
> /** @file
>   Provides interface to shell functionality for shell commands and applications.
>
>-  Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
>+  Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>   This program and the accompanying materials
>   are licensed and made available under the terms and conditions of the BSD
>License
>   which accompanies this distribution.  The full text of the license may be
>found at
>@@ -32,9 +32,6 @@
>     }                                 \
>   } while(FALSE)
>
>-// (20 * (6+5+2))+1) unicode characters from EFI FAT spec (doubled for bytes)
>-#define MAX_FILE_NAME_LEN 512
>-
> extern EFI_SHELL_PARAMETERS_PROTOCOL *gEfiShellParametersProtocol;
> extern EFI_SHELL_PROTOCOL            *gEfiShellProtocol;
>
>diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
>b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
>index c3a67c3be7..64565f81d8 100644
>--- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
>+++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
>@@ -18,8 +18,6 @@
> #include <Library/SortLib.h>
> #include <Library/BaseLib.h>
>
>-#define FIND_XXXXX_FILE_BUFFER_SIZE (SIZE_OF_EFI_FILE_INFO +
>MAX_FILE_NAME_LEN)
>-
> //
> // globals...
> //
>--
>2.12.2.windows.2



      reply	other threads:[~2017-07-27  3:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26  9:34 [PATCH] ShellPkg/ShellLib: Remove unused macros Ruiyu Ni
2017-07-27  3:38 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D75C6B6@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox