From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D7C1721D491BB for ; Wed, 26 Jul 2017 20:37:17 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2017 20:39:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,418,1496127600"; d="scan'208";a="1199760380" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 26 Jul 2017 20:39:18 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Jul 2017 20:38:08 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Thu, 27 Jul 2017 11:38:06 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [PATCH] ShellPkg/ShellLib: Remove unused macros Thread-Index: AQHTBfJsbJVvBpSfrE+qHhIOiVNkiqJnB5fQ Date: Thu, 27 Jul 2017 03:38:06 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D75C6B6@shsmsx102.ccr.corp.intel.com> References: <20170726093422.36684-1-ruiyu.ni@intel.com> In-Reply-To: <20170726093422.36684-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/ShellLib: Remove unused macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2017 03:37:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Ni, Ruiyu >Sent: Wednesday, July 26, 2017 5:34 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [PATCH] ShellPkg/ShellLib: Remove unused macros > >MAX_FILE_NAME_LEN and FIND_XXXXX_FILE_BUFFER_SIZE are not used >by ShellLib so remove them. > >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Ruiyu Ni >Cc: Michael D Kinney >Cc: Liming Gao >--- > ShellPkg/Include/Library/ShellLib.h | 5 +---- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 -- > 2 files changed, 1 insertion(+), 6 deletions(-) > >diff --git a/ShellPkg/Include/Library/ShellLib.h >b/ShellPkg/Include/Library/ShellLib.h >index 9b611d8016..268a767b70 100644 >--- a/ShellPkg/Include/Library/ShellLib.h >+++ b/ShellPkg/Include/Library/ShellLib.h >@@ -1,7 +1,7 @@ > /** @file > Provides interface to shell functionality for shell commands and applic= ations. > >- Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
>+ Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the B= SD >License > which accompanies this distribution. The full text of the license may = be >found at >@@ -32,9 +32,6 @@ > } \ > } while(FALSE) > >-// (20 * (6+5+2))+1) unicode characters from EFI FAT spec (doubled for by= tes) >-#define MAX_FILE_NAME_LEN 512 >- > extern EFI_SHELL_PARAMETERS_PROTOCOL *gEfiShellParametersProtocol; > extern EFI_SHELL_PROTOCOL *gEfiShellProtocol; > >diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c >b/ShellPkg/Library/UefiShellLib/UefiShellLib.c >index c3a67c3be7..64565f81d8 100644 >--- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c >+++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c >@@ -18,8 +18,6 @@ > #include > #include > >-#define FIND_XXXXX_FILE_BUFFER_SIZE (SIZE_OF_EFI_FILE_INFO + >MAX_FILE_NAME_LEN) >- > // > // globals... > // >-- >2.12.2.windows.2