From: "Gao, Liming" <liming.gao@intel.com>
To: "Ruffin, Chris" <chris.ruffin@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] BaseTools/Conf: apply nasmb, asm16 build rule order
Date: Thu, 3 Aug 2017 15:08:40 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D75F4E4@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170802203006.62216-1-chris.ruffin@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Chris Ruffin
> Sent: Thursday, August 3, 2017 4:30 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] BaseTools/Conf: apply nasmb, asm16 build rule order
>
> Prioritize nasmb rule over asm16 where both source types are specified.
>
> Change-Id: I33ec348dab66b313ddb05cb15f2d8407a648c320
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chris Ruffin <chris.ruffin@intel.com>
> ---
> BaseTools/Conf/tools_def.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 4b1b7b548c..689b6ec501 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -7756,4 +7756,4 @@ RELEASE_RVCTCYGWIN_ARM_CC_FLAGS = "$(CCPATH_FLAG)" $(ARCHCC_FLAGS) $(PLATFORM_F
> #################
> # Build rule order
> #################
> -*_*_*_*_BUILDRULEORDER = nasm asm Asm ASM S s
> +*_*_*_*_BUILDRULEORDER = nasm asm Asm ASM S s nasmb asm16
> --
> 2.13.3.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-08-03 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 20:30 [PATCH] BaseTools/Conf: apply nasmb, asm16 build rule order Chris Ruffin
2017-08-03 15:08 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D75F4E4@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox