From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 264032095DE59 for ; Thu, 10 Aug 2017 03:42:06 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2017 03:44:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,352,1498546800"; d="scan'208";a="1204112003" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 10 Aug 2017 03:44:24 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 10 Aug 2017 03:44:24 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 10 Aug 2017 02:48:52 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.183]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.128]) with mapi id 14.03.0319.002; Thu, 10 Aug 2017 17:48:51 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Fan, Jeff" , Andrew Fish Thread-Topic: [Patch V2 3/4] IntelFrameworkModulePkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined Thread-Index: AQHTDDbwQuTdI/+uCEyDQiJ8eqRXOaJ9Y0gQ Date: Thu, 10 Aug 2017 09:48:49 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D76DA5D@shsmsx102.ccr.corp.intel.com> References: <1501750792-31020-1-git-send-email-yonghong.zhu@intel.com> <1501750792-31020-4-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1501750792-31020-4-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch V2 3/4] IntelFrameworkModulePkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 10:42:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Zhu, Yonghong > Sent: Thursday, August 3, 2017 5:00 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D ; Fan, Jeff ; Andrew > Fish > Subject: [Patch V2 3/4] IntelFrameworkModulePkg: Fix Xcode 9 Beta treatin= g 32-bit left shift as undefined >=20 > Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=3D635 >=20 > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Jeff Fan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Andrew Fish > --- > .../BaseUefiTianoCustomDecompressLib.c | 6 = +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompres= sLib/BaseUefiTianoCustomDecompressLib.c > b/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUe= fiTianoCustomDecompressLib.c > index e0ba053..5d64f02 100644 > --- a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/Ba= seUefiTianoCustomDecompressLib.c > +++ b/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/Ba= seUefiTianoCustomDecompressLib.c > @@ -28,18 +28,18 @@ FillBuf ( > ) > { > // > // Left shift NumOfBits of bits in advance > // > - Sd->mBitBuf =3D (UINT32) (Sd->mBitBuf << NumOfBits); > + Sd->mBitBuf =3D (UINT32) LShiftU64 (((UINT64)Sd->mBitBuf), NumOfBits); >=20 > // > // Copy data needed in bytes into mSbuBitBuf > // > while (NumOfBits > Sd->mBitCount) { > - > - Sd->mBitBuf |=3D (UINT32) (Sd->mSubBitBuf << (NumOfBits =3D (UINT16)= (NumOfBits - Sd->mBitCount))); > + NumOfBits =3D (UINT16) (NumOfBits - Sd->mBitCount); > + Sd->mBitBuf |=3D (UINT32) LShiftU64 (((UINT64)Sd->mSubBitBuf), NumOf= Bits); >=20 > if (Sd->mCompSize > 0) { > // > // Get 1 byte into SubBitBuf > // > -- > 2.6.1.windows.1