From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4DE2F21E2DA62 for ; Thu, 17 Aug 2017 00:57:54 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 17 Aug 2017 01:00:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,386,1498546800"; d="scan'208,217";a="124641940" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 17 Aug 2017 01:00:20 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 17 Aug 2017 01:00:20 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 17 Aug 2017 01:00:20 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.183]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.25]) with mapi id 14.03.0319.002; Thu, 17 Aug 2017 16:00:17 +0800 From: "Gao, Liming" To: "Yao, Jiewen" , "Song, BinX" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API Thread-Index: AdMMG/VCDGqeDKeqTI69ZqXwtAZABgAPMRzQAAQP0tACsSJgEAAAUJkw Date: Thu, 17 Aug 2017 08:00:17 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D772BBF@shsmsx102.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF102583089@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503A98296A@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D75F4AB@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503A992999@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A992999@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi API X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Aug 2017 07:57:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. This way does work. We will update the patch for it. From: Yao, Jiewen Sent: Thursday, August 17, 2017 3:53 PM To: Gao, Liming ; Song, BinX ; e= dk2-devel@lists.01.org Subject: RE: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi A= PI Thanks for the explanation. Yes, I agree we need resolve the build issue. I do not suggest to remove the API in SecFspSecPlatformLibNull, because we = need provide a good sample to real FSP implementation. Can we add empty symbol in FspApiEntryM.nasm and FspApiEntryS.nasm? Thank you Yao Jiewen From: Gao, Liming Sent: Thursday, August 3, 2017 11:05 PM To: Yao, Jiewen >; Song, = BinX >; edk2-devel@lists.01= .org Subject: RE: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi A= PI Jiewen: The change is in SecFspSecPlatformLibNull. This library instance provides= the dummy function. It should not be used by any real FSP. We meet with th= e build issue with /WHOLEARCHIVE option. Because this library depends on th= e external TempRamInitApi(), but FspSecCoreS and FspSecCoreT don't provide = TempRamInitApi(). Then, FspSecCoreS and FspSecCoreT will build failure. To = fix this build failure, we choose to remove this unnecessary dependency. > > global ASM_PFX(ProtectedModeEntryPoint) > > ASM_PFX(ProtectedModeEntryPoint): > > - ; > > - ; Dummy function. Consume 2 API to make sure they can be linked. > > - ; Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ya= o, Jiewen > Sent: Thursday, August 3, 2017 9:03 PM > To: Song, BinX >; edk2-de= vel@lists.01.org > Cc: Giri P Mudusuru > > Subject: Re: [edk2] [PATCH] IntelFsp2Pkg: Delete useless external TempRam= InitApi API > > Hi > May I know what test you have done to remove this? > > Have you built a real FSP and boot it with FSP Wrapper? > > Thank you > Yao Jiewen > > > -----Original Message----- > > From: Song, BinX > > Sent: Thursday, August 3, 2017 1:47 PM > > To: edk2-devel@lists.01.org > > Cc: Yao, Jiewen >; Gi= ri P Mudusuru > > > > > Subject: [PATCH] IntelFsp2Pkg: Delete useless external TempRamInitApi A= PI > > > > - Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build > > error with VS2015 tool chain > > > > Cc: Jiewen Yao > > > Cc: Giri P Mudusuru > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Bell Song > > > --- > > IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm | 7 ---= ---- > > 1 file changed, 7 deletions(-) > > > > diff --git a/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.= nasm > > b/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm > > index 122eb9e..ee78312 100644 > > --- a/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm > > +++ b/IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/Ia32/Flat32.nasm > > @@ -16,8 +16,6 @@ > > ; Define assembler characteristics > > ; > > > > -extern ASM_PFX(TempRamInitApi) > > - > > SECTION .text > > > > %macro RET_ESI 0 > > @@ -66,11 +64,6 @@ ASM_PFX(SecPlatformInit): > > ;---------------------------------------------------------------------= ------- > > global ASM_PFX(ProtectedModeEntryPoint) > > ASM_PFX(ProtectedModeEntryPoint): > > - ; > > - ; Dummy function. Consume 2 API to make sure they can be linked. > > - ; > > - mov eax, ASM_PFX(TempRamInitApi) > > - > > ; Should never return > > jmp $ > > > > -- > > 2.10.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel