From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 480E921D2E621 for ; Sun, 20 Aug 2017 19:34:35 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 20 Aug 2017 19:37:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,406,1498546800"; d="scan'208";a="140037566" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 20 Aug 2017 19:37:06 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 20 Aug 2017 19:37:05 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 20 Aug 2017 19:37:05 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.183]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.236]) with mapi id 14.03.0319.002; Mon, 21 Aug 2017 10:37:03 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , Paulo Alcantara , "edk2-devel@lists.01.org" CC: Laszlo Ersek , "Justen, Jordan L" , Andrew Fish , "Kinney, Michael D" , "Zeng, Star" , "Dong, Eric" , "Doran, Mark" , "Wu, Hao A" Thread-Topic: [PATCH v2 0/6] read-only UDF file system support Thread-Index: AQHTGeCKm7WgvRjzMU2i7cQLkJlPCKKNkMAAgACH8rA= Date: Mon, 21 Aug 2017 02:37:03 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D7738EA@shsmsx102.ccr.corp.intel.com> References: <20170820181557.28761-1-pcacjr@zytor.com> <734D49CCEBEEF84792F5B80ED585239D5B9F3CD8@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5B9F3CD8@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/6] read-only UDF file system support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 02:34:35 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I suggest to run PatchCheck tool first. It is mentioned in https://github.c= om/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process >-----Original Message----- >From: Ni, Ruiyu >Sent: Monday, August 21, 2017 10:29 AM >To: Paulo Alcantara ; edk2-devel@lists.01.org >Cc: Laszlo Ersek ; Justen, Jordan L >; Andrew Fish ; Kinney, >Michael D ; Gao, Liming >; Zeng, Star ; Dong, Eric >; Doran, Mark ; Wu, Hao A > >Subject: RE: [PATCH v2 0/6] read-only UDF file system support > >Paulo, >1. Could you please run the ECC check tool (BaseTools\Source\Python\Ecc\) > "CRC" might need to be replaced with "Crc". > I also noticed some TAB key in file content. > >2. Your current implementation uses HARD_DRIVE_DEVICE_PATH. > But with: > SignatureType =3D SIGNATURE_TYPE_UDF > MBRType =3D MBR_TYPE_PCAT > Signature =3D * > And later UdfDxe driver checks the SignatureType and MBRType. > I am not sure if it would be better to put the definitions in UEFI Spec, > since they are referenced by different modules. > I also noticed you use PARTITION_TYPE_OTHER for PartitionInfo. > When proposing to UEFI Spec, this also needs to be considered, > for example, add PARTITION_TYPE_UDF to spec. > >3. The driver model part looks good. > >Regards, >Ray > >>-----Original Message----- >>From: Paulo Alcantara [mailto:pcacjr@zytor.com] >>Sent: Monday, August 21, 2017 2:16 AM >>To: edk2-devel@lists.01.org >>Cc: Paulo Alcantara ; Laszlo Ersek ; >Justen, Jordan L ; >>Andrew Fish ; Kinney, Michael D >; Gao, Liming ; >>Zeng, Star ; Dong, Eric ; Doran= , >Mark ; Ni, Ruiyu >>; Wu, Hao A >>Subject: [PATCH v2 0/6] read-only UDF file system support >> >>Hi, >> >>This series introduces read-only UDF file system support in EDK2. As >>Laszlo (or Red Hat) seemed to be interested in such support, I'm posting >>it again after ~3 years. >> >>The idea is not replacing the default FAT file system, nor breaking any >>existing file system support, but extending EDK2 with a new file system >>that might be useful for some people who are looking for specific file >>system features that current FAT doesn't support. >> >>Originally the driver was written to support UDF file systems as >>specified by OSTA Universal Disk Format Specification 2.60. However, >>some Windows 10 Enterprise ISO (UDF bridge) images that I tested >>supported a revision of 1.02 thus I had to rework the driver a little >>bit to support such revision as well. >> >>v2: >> - Rework to _partially_ support UDF revisions <2.60. >> - Use existing CDROM_VOLUME_DESCRIPTOR structure defined in Eltorito.h >> instead of creating another one (UDF_VOLUME_DESCRIPTOR). >> - Fixed UdfDxe to correctly follow UEFI driver model. >> - Use HARDDRIVE_DEVICE_PATH instead of a vendor-defined one. >> - Detect UDF file systems only in PartitionDxe, and let UdfDxe driver >> check for specific UDF device path to decide whether or not install >> SimpleFs protocol. >> - Place MdePkg changes in a separate patch. >> >>Repo: https://github.com/pcacjr/edk2.git >>Branch: udf-fs >> >>Cc: Laszlo Ersek >>Cc: Jordan Justen >>Cc: Andrew Fish >>Cc: Michael D Kinney >>Cc: Liming Gao >>Cc: Star Zeng >>Cc: Eric Dong >>Cc: Mark Doran >>Cc: Ruiyu Ni >>Cc: hao.a.wu@intel.com >>Contributed-under: TianoCore Contribution Agreement 1.1 >>Signed-off-by: Paulo Alcantara >>--- >> >>Paulo Alcantara (6): >> MdePkg: Add UDF volume structure definitions >> MdeModulePkg/PartitionDxe: Add UDF file system support >> MdeModulePkg: Initial UDF/ECMA-167 file system support >> OvmfPkg: Enable UDF file system support >> ArmVirtPkg: Enable UDF file system support >> Nt32Pkg: Enable UDF file system support >> >> ArmVirtPkg/ArmVirtQemu.dsc | 3 +- >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 +- >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 3 +- >> ArmVirtPkg/ArmVirtXen.dsc | 3 +- >> ArmVirtPkg/ArmVirtXen.fdf | 1 + >> .../Universal/Disk/PartitionDxe/Partition.c | 9 +- >> .../Universal/Disk/PartitionDxe/Partition.h | 32 +- >> .../Universal/Disk/PartitionDxe/PartitionDxe.inf | 3 +- >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 307 +++ >> MdeModulePkg/Universal/Disk/UdfDxe/ComponentName.c | 185 ++ >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 901 ++++++++ >> MdeModulePkg/Universal/Disk/UdfDxe/FileName.c | 195 ++ >> .../Universal/Disk/UdfDxe/FileSystemOperations.c | 2375 >++++++++++++++++++++ >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.c | 415 ++++ >> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 1246 ++++++++++ >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 66 + >> MdePkg/Include/IndustryStandard/Udf.h | 60 + >> Nt32Pkg/Nt32Pkg.dsc | 1 + >> Nt32Pkg/Nt32Pkg.fdf | 1 + >> OvmfPkg/OvmfPkgIa32.dsc | 1 + >> OvmfPkg/OvmfPkgIa32.fdf | 1 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >> OvmfPkg/OvmfPkgIa32X64.fdf | 1 + >> OvmfPkg/OvmfPkgX64.dsc | 1 + >> OvmfPkg/OvmfPkgX64.fdf | 1 + >> 25 files changed, 5804 insertions(+), 11 deletions(-) >> create mode 100644 MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c >> create mode 100644 >MdeModulePkg/Universal/Disk/UdfDxe/ComponentName.c >> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/File.c >> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/FileName.c >> create mode 100644 >MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c >> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/Udf.c >> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/Udf.h >> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> create mode 100644 MdePkg/Include/IndustryStandard/Udf.h >> >>-- >>2.11.0