public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Song, BinX" <binx.song@intel.com>, "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option
Date: Mon, 21 Aug 2017 08:19:49 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D773B02@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com>

Bin:
  Please remove VS2015 from the comments in source files. 

Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Song, BinX
>Sent: Monday, August 21, 2017 2:35 PM
>To: Yao, Jiewen <jiewen.yao@intel.com>
>Cc: edk2-devel@lists.01.org
>Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE
>option
>
>V2:
>- Recover TempRamInitApi API and add dummy TempRamInitApi function to
>fix
>  build error with WHOLEARCHIVE option
>
>V1:
>- Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build
>  error with VS2015 tool chain
>
>Cc: Jiewen Yao <jiewen.yao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Bell Song <binx.song@intel.com>
>---
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++
> 2 files changed, 20 insertions(+)
>
>diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>index 9744e16..81b531e 100644
>--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm
>@@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset):
>    ret
>
> ;----------------------------------------------------------------------------
>+; TempRamInit API
>+;
>+; Dummy function for VS2015 WHOLEARCHIVE build option
>+;
>+;----------------------------------------------------------------------------
>+global ASM_PFX(TempRamInitApi)
>+ASM_PFX(TempRamInitApi):
>+  ret
>+
>+;----------------------------------------------------------------------------
> ; Module Entrypoint API
> ;----------------------------------------------------------------------------
> global ASM_PFX(_ModuleEntryPoint)
>diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>index cdc1149..06a791f 100644
>--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm
>@@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue):
>   ret
>
> ;----------------------------------------------------------------------------
>+; TempRamInit API
>+;
>+; Dummy function for VS2015 WHOLEARCHIVE build option
>+;
>+;----------------------------------------------------------------------------
>+global ASM_PFX(TempRamInitApi)
>+ASM_PFX(TempRamInitApi):
>+  ret
>+
>+;----------------------------------------------------------------------------
> ; Module Entrypoint API
> ;----------------------------------------------------------------------------
> global ASM_PFX(_ModuleEntryPoint)
>--
>2.10.2.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


       reply	other threads:[~2017-08-21  8:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com>
2017-08-21  8:19 ` Gao, Liming [this message]
2017-08-21  8:21   ` [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option Song, BinX
2017-08-21  8:25 ` Yao, Jiewen
2017-08-21  8:28   ` Song, BinX
2017-08-22 22:26 ` Kinney, Michael D
2017-08-23  2:34   ` Gao, Liming
2017-08-23  2:54     ` Yao, Jiewen
2017-08-23  3:01       ` Song, BinX
2017-08-23  3:03         ` Yao, Jiewen
2017-08-23  3:04           ` Song, BinX
2017-08-23 16:08     ` Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14D773B02@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox