From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 006EC21E49BA2 for ; Tue, 22 Aug 2017 04:54:42 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2017 04:57:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,412,1498546800"; d="scan'208";a="1006362884" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 22 Aug 2017 04:57:14 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 Aug 2017 04:57:14 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 Aug 2017 04:57:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.183]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.135]) with mapi id 14.03.0319.002; Tue, 22 Aug 2017 19:57:12 +0800 From: "Gao, Liming" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [PATCH V4 0/3] Add HII Popup Protocol Thread-Index: AQHTGxbM6vKqi82ZBU6fbwbuwuYYrKKQQ/pw Date: Tue, 22 Aug 2017 11:57:11 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D774389@shsmsx102.ccr.corp.intel.com> References: <1503386264-312072-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1503386264-312072-1-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V4 0/3] Add HII Popup Protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 11:54:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Dandan: I have one minor comments. This protocol is in UEFI2.7. Please add it bel= ow UEFI2.7 comment in MdePkg.dec Thanks Liming > -----Original Message----- > From: Bi, Dandan > Sent: Tuesday, August 22, 2017 3:18 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Gao, Liming > Subject: [PATCH V4 0/3] Add HII Popup Protocol >=20 > Patch 1: Add the definition of HII Popup Protocol. > Patch 2: Add the implementation of HII Popup Protocol. > Patch 3: Add one sample use case of HII Popup Protocol. >=20 > V4: > Updates in pacth 2: > Add more comments and remove one unnecessary > check in function ParseMessageString(). >=20 > V3: > Updates in pacth 2: > Separate DrawMessageBox() function into CalculatePopupPosition() > DrawMessageBox() and GetUserSelection() three functions and refine > related codes. >=20 > V2: > Updates in pacth 2: > Addstring "ERROR", "WARNING", "INFO" at the top of the message box > to implement the different appearances for different styles of Popup. > Updates in pacth 3: > Update the date info in the Copyright. >=20 > Cc: Eric Dong > Cc: Liming Gao > Dandan Bi (3): > MdePkg/HiiPopup: Add HII Popup Protocol definitions > MdeModulePkg/DisplayEngine: Add implementation of HiiPopup protocol > MdeModulePkg/DriverSample: Add sample case for popup protocol >=20 > .../DisplayEngineDxe/DisplayEngineDxe.inf | 4 +- > .../Universal/DisplayEngineDxe/FormDisplay.c | 42 ++ > .../Universal/DisplayEngineDxe/FormDisplay.h | 96 ++- > .../Universal/DisplayEngineDxe/FormDisplayStr.uni | 20 +- > MdeModulePkg/Universal/DisplayEngineDxe/Popup.c | 730 +++++++++++++++= ++++++ > .../Universal/DriverSampleDxe/DriverSample.c | 29 + > .../Universal/DriverSampleDxe/DriverSample.h | 4 +- > .../Universal/DriverSampleDxe/DriverSampleDxe.inf | 3 +- > MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 10 +- > .../Universal/DriverSampleDxe/VfrStrings.uni | 8 +- > MdePkg/Include/Protocol/HiiPopup.h | 81 +++ > MdePkg/MdePkg.dec | 3 + > 12 files changed, 1022 insertions(+), 8 deletions(-) > create mode 100644 MdeModulePkg/Universal/DisplayEngineDxe/Popup.c > create mode 100644 MdePkg/Include/Protocol/HiiPopup.h >=20 > -- > 1.9.5.msysgit.1