From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8C33921E3EA63 for ; Mon, 4 Sep 2017 20:07:40 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 20:10:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,477,1498546800"; d="scan'208";a="145471340" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 04 Sep 2017 20:10:28 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 20:10:28 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 20:10:27 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.39]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.219]) with mapi id 14.03.0319.002; Tue, 5 Sep 2017 11:10:26 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Shaw, Kevin W" Thread-Topic: [Patch] DSC Spec: Hii type Pcd VariableName is NOT allowed to be empty string Thread-Index: AQHTJfRPwxaX/+toB0OIHN9H+yDqAaKlnRoA Date: Tue, 5 Sep 2017 03:10:25 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D789FCA@shsmsx102.ccr.corp.intel.com> References: <1504580930-61952-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1504580930-61952-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] DSC Spec: Hii type Pcd VariableName is NOT allowed to be empty string X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 03:07:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Zhu, Yonghong > Sent: Tuesday, September 5, 2017 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D ; Shaw, Kevin W > Subject: [Patch] DSC Spec: Hii type Pcd VariableName is NOT allowed to be= empty string >=20 > fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3D597 > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > 2_dsc_overview/29_pcd_sections.md | 4 ++++ > 3_edk_ii_dsc_file_format/310_pcd_sections.md | 6 ++++++ > README.md | 1 + > 3 files changed, 11 insertions(+) >=20 > diff --git a/2_dsc_overview/29_pcd_sections.md b/2_dsc_overview/29_pcd_se= ctions.md > index 83689a9..6547656 100644 > --- a/2_dsc_overview/29_pcd_sections.md > +++ b/2_dsc_overview/29_pcd_sections.md > @@ -250,10 +250,12 @@ described in the following table. > | `NV` | `EFI_VARIABLE_NON_VOLATILE` | `0x00000001` | > | `BS` | `EFI_VARIABLE_BOOTSERVICE_ACCESS` | `0x00000002` | > | `RT` | `EFI_VARIABLE_RUNTIME_ACCESS` | `0x00000004` | > | `RO` | `VAR_CHECK_VARIABLE_PROPERTY_READ_ONLY` | `BIT0` | >=20 > +**Note:** The VariableName field in the HII format PCD entry must not be= an empty string. > + > #### Examples >=20 > ```ini > [PcdsDynamicHii.common.Sku_Two] > NoSuchTokenSpaceGuid.PcdPreAllocatedMem| 0x0053 0x0065 0x0074 0x0075 0= x0070|gSysconfigGuid|0x000000A9|0x3 > @@ -345,10 +347,12 @@ backslash character is used here to indicate the co= ntinuation of the line: > `PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffse= t[|HiiDefaultValue]` >=20 > The optional HII Attribute entry is a comma separated list of attributes= as > described in Table 9 HII Attributes. >=20 > +**Note:** The VariableName field in the HII format PCD entry must not be= an empty string. > + > #### Examples >=20 > ```ini > [PcdsDynamicExHii.IA32.Sku_Two] > gNoSuchTokenSpaceGuid.PcdPreAllocatedMem|0x0053 0x0065 0x0074 0x0075 0= x0070|gSysconfigGuid|0x000000A9|0x11 > diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_= file_format/310_pcd_sections.md > index c061e5b..2af42cc 100644 > --- a/3_edk_ii_dsc_file_format/310_pcd_sections.md > +++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md > @@ -514,10 +514,13 @@ of the offset. >=20 > A non-negative numeric value that is the number of bytes from the start = to the > start of this variable. The offset value must not exceed the maximum val= ue of > 0xFFFF (`UINT16`). >=20 > +**_HiiString_** > +The HiiString field in the HII format PCD entry must not be an empty str= ing. > + > **_SkuIds_** >=20 > `SkuId`s in the DSC file can be used in two different ways. They can be = used to > as conditional modifiers to exclude some content from a build, or they c= an be > used to identify and group content during a build. If no `SkuId` option = (`-x`) > @@ -671,10 +674,13 @@ of the offset. >=20 > A non-negative numeric value that is the number of bytes from the start = to the > start of this variable. The offset value must not exceed the maximum val= ue of > 0xFFFF (`UINT16`). >=20 > +**_HiiString_** > +The HiiString field in the HII format PCD entry must not be an empty str= ing. > + > **_SkuIds_** >=20 > `SkuId`s in the DSC file can be used in two different ways. They can be = used to > as conditional modifiers to exclude some content from a build, or they c= an be > used to identify and group content during a build. If no `SkuId` option = (`-x`) > diff --git a/README.md b/README.md > index 270857e..dd3419a 100644 > --- a/README.md > +++ b/README.md > @@ -183,5 +183,6 @@ Copyright (c) 2006-2017, Intel Corporation. All right= s reserved. > | | [#521](https://bugzilla.tianocore.org/show_bug.cgi?id=3D5= 21) DSC spec: add clarification for mixed PCD usage in the > DSC spec > | | > | | [#519](https://bugzilla.tianocore.org/show_bug.cgi?id=3D5= 19) DSC Spec: update Precedence of PCD Values > | | > | | [#584](https://bugzilla.tianocore.org/show_bug.cgi?id=3D5= 84) DSC Spec: Update the DSC_SPECIFICATION version to > 0x0001001B or 1.27 > | | > | | [#645](https://bugzilla.tianocore.org/show_bug.cgi?id=3D6= 45) DSC Spec: Remove Restriction on Using NULL in > [LibraryClasses] Section > | | > | | [#669](https://bugzilla.tianocore.org/show_bug.cgi?id=3D6= 69) DSC Spec: Add multi-arg support to > PREBUILD/POSTBUILD > | | > +| | [#597](https://bugzilla.tianocore.org/show_bug.cgi?id=3D5= 97) DSC Spec: Hii type Pcd VariableName is NOT allowed to > be empty string > | | > -- > 2.6.1.windows.1