From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B36F821EA35C4 for ; Thu, 7 Sep 2017 02:21:55 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Sep 2017 02:24:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,357,1500966000"; d="scan'208";a="1215847368" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 07 Sep 2017 02:24:46 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Sep 2017 02:24:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.39]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Thu, 7 Sep 2017 17:24:41 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Not show *B when Pcd value in build option same with DEC Thread-Index: AQHTJVnESVwJvwdju0W70ADsPC9RcqKpK4rw Date: Thu, 7 Sep 2017 09:24:40 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14D78B5B3@shsmsx102.ccr.corp.intel.com> References: <1504514529-57948-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1504514529-57948-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Not show *B when Pcd value in build option same with DEC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 09:21:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, September 04, 2017 4:42 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: Not show *B when Pcd value in build >option same with DEC > >Per build spec, If the value obtained from either a build option, the >DSC or FDF is the same as the value in the DEC, then *B , *P or *F >will not be shown in the report. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/BuildReport.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/BaseTools/Source/Python/build/BuildReport.py >b/BaseTools/Source/Python/build/BuildReport.py >index a7cbb6a..38ee26d 100644 >--- a/BaseTools/Source/Python/build/BuildReport.py >+++ b/BaseTools/Source/Python/build/BuildReport.py >@@ -969,14 +969,14 @@ class PcdReport(object): > DscMatch =3D (DscDefaultValue.strip() =3D=3D = PcdValue.strip()) > > # > # Report PCD item according to their override relatio= nship > # >- if BuildOptionMatch: >- FileWrite(File, ' *B %-*s: %6s %10s =3D %-22s' % = (self.MaxLen, >PcdTokenCName, TypeName, '(' + Pcd.DatumType + ')', PcdValue.strip())) >- elif DecMatch and InfMatch: >+ if DecMatch and InfMatch: > FileWrite(File, ' %-*s: %6s %10s =3D %-22s' % = (self.MaxLen, >PcdTokenCName, TypeName, '(' + Pcd.DatumType + ')', PcdValue.strip())) >+ elif BuildOptionMatch: >+ FileWrite(File, ' *B %-*s: %6s %10s =3D %-22s' % = (self.MaxLen, >PcdTokenCName, TypeName, '(' + Pcd.DatumType + ')', PcdValue.strip())) > else: > if DscMatch: > if (Pcd.TokenCName, Key) in self.FdfPcdSet: > FileWrite(File, ' *F %-*s: %6s %10s =3D %= -22s' % (self.MaxLen, >PcdTokenCName, TypeName, '(' + Pcd.DatumType + ')', PcdValue.strip())) > else: >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel