public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] BaseTools: correct to use specific arch to generate DSC database
@ 2017-09-07 13:29 Yonghong Zhu
  2017-09-08  5:34 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2017-09-07 13:29 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao

Not generic to use 'Common' arch, but use current build arch.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/Workspace/WorkspaceDatabase.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
index fe2c7c1..b617221 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
@@ -3107,11 +3107,11 @@ determine whether database file is out of date!\n")
 
     ## Summarize all packages in the database
     def GetPackageList(self, Platform, Arch, TargetName, ToolChainTag):
         self.Platform = Platform
         PackageList = []
-        Pa = self.BuildObject[self.Platform, 'COMMON']
+        Pa = self.BuildObject[self.Platform, Arch]
         #
         # Get Package related to Modules
         #
         for Module in Pa.Modules:
             ModuleObj = self.BuildObject[Module, Arch, TargetName, ToolChainTag]
-- 
2.6.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] BaseTools: correct to use specific arch to generate DSC database
  2017-09-07 13:29 [Patch] BaseTools: correct to use specific arch to generate DSC database Yonghong Zhu
@ 2017-09-08  5:34 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2017-09-08  5:34 UTC (permalink / raw)
  To: Zhu, Yonghong, edk2-devel@lists.01.org

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Thursday, September 07, 2017 9:29 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [edk2] [Patch] BaseTools: correct to use specific arch to generate DSC
>database
>
>Not generic to use 'Common' arch, but use current build arch.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/Workspace/WorkspaceDatabase.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
>b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
>index fe2c7c1..b617221 100644
>--- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
>+++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
>@@ -3107,11 +3107,11 @@ determine whether database file is out of
>date!\n")
>
>     ## Summarize all packages in the database
>     def GetPackageList(self, Platform, Arch, TargetName, ToolChainTag):
>         self.Platform = Platform
>         PackageList = []
>-        Pa = self.BuildObject[self.Platform, 'COMMON']
>+        Pa = self.BuildObject[self.Platform, Arch]
>         #
>         # Get Package related to Modules
>         #
>         for Module in Pa.Modules:
>             ModuleObj = self.BuildObject[Module, Arch, TargetName,
>ToolChainTag]
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-08  5:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 13:29 [Patch] BaseTools: correct to use specific arch to generate DSC database Yonghong Zhu
2017-09-08  5:34 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox