From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5A84421CEB0F9 for ; Mon, 18 Sep 2017 23:59:12 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2017 00:02:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,416,1500966000"; d="scan'208";a="153455116" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 19 Sep 2017 00:02:16 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Sep 2017 00:02:16 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Sep 2017 00:02:15 -0700 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.93]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Tue, 19 Sep 2017 15:02:13 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch V2] BaseTools: Fix a bug to correct SourceFileList Thread-Index: AQHTMDX2XNyYNbeOPUOhCLU1n+SnkaK7yfHA Date: Tue, 19 Sep 2017 07:02:13 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E15A5F8@SHSMSX152.ccr.corp.intel.com> References: <1505708635-17576-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1505708635-17576-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch V2] BaseTools: Fix a bug to correct SourceFileList X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 06:59:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Monday, September 18, 2017 12:24 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch V2] BaseTools: Fix a bug to correct SourceFileList > >We met a case that use two microcode files in the Microcode.inf file, >one is .mcb file, another is .txt file. then it cause build failure >because the SourceFileList include the .txt file's output file, while >this output file is still not be generated, so it cause >GetFileDependency report failure. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/AutoGen/GenMake.py | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py >b/BaseTools/Source/Python/AutoGen/GenMake.py >index 0f3ddd5..942eb44 100644 >--- a/BaseTools/Source/Python/AutoGen/GenMake.py >+++ b/BaseTools/Source/Python/AutoGen/GenMake.py >@@ -787,12 +787,19 @@ cleanlib: > ForceIncludedFile =3D [] > for File in self._AutoGenObject.AutoGenFileList: > if File.Ext =3D=3D '.h': > ForceIncludedFile.append(File) > SourceFileList =3D [] >+ OutPutFileList =3D [] > for Target in self._AutoGenObject.IntroTargetList: > SourceFileList.extend(Target.Inputs) >+ OutPutFileList.extend(Target.Outputs) >+ >+ if OutPutFileList: >+ for Item in OutPutFileList: >+ if Item in SourceFileList: >+ SourceFileList.remove(Item) > > self.FileDependency =3D self.GetFileDependency( > SourceFileList, > ForceIncludedFile, > self._AutoGenObject.IncludePathList + >self._AutoGenObject.BuildOptionIncPathList >-- >2.6.1.windows.1