From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6702921E1B75A for ; Sun, 24 Sep 2017 22:24:15 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2017 22:27:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="1018002104" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 24 Sep 2017 22:27:25 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 22:27:25 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 22:27:24 -0700 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.93]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 13:27:22 +0800 From: "Gao, Liming" To: Leif Lindholm , Laszlo Ersek CC: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Justen, Jordan L" , Andrew Fish , Ard Biesheuvel , "Zhu, Yonghong" Thread-Topic: [edk2] [RFC 0/6] Create central repository for boilerplate configuration Thread-Index: AQHTMjXl5dMNcOoBrkqbXOB0hr+YUaK9jjWAgAAwooCAAoBZgIAB8KOAgALiPGA= Date: Mon, 25 Sep 2017 05:27:21 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E15CCDA@SHSMSX152.ccr.corp.intel.com> References: <20170920172755.22767-1-leif.lindholm@linaro.org> <20170920210903.tdpj6prki4ikrlth@bivouac.eciton.net> <20170923165829.p3a2qej2rbz2adm2@bivouac.eciton.net> In-Reply-To: <20170923165829.p3a2qej2rbz2adm2@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [RFC 0/6] Create central repository for boilerplate configuration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 05:24:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo and Leif: PCD value are the position relation. In DSC file, the latter one will ove= rride the first one. But, PCD type can't be overridden. For example, if PCD= is listed in [PcdsFixedAtBuild] section in the config.inc, PCD can't be li= sted in [PcdsPatchableInModule] section in Platform.dsc. I think Platform m= ay not only override PCD value, but also override PCD type. To meet with pl= atform requirement, we had better not place PCD setting in common DSC file.= =20 Thanks Liming >-----Original Message----- >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >Sent: Sunday, September 24, 2017 12:58 AM >To: Laszlo Ersek >Cc: edk2-devel@lists.01.org; Kinney, Michael D >; Justen, Jordan L = ; >Andrew Fish ; Ard Biesheuvel >; Gao, Liming ; Zhu, >Yonghong >Subject: Re: [edk2] [RFC 0/6] Create central repository for boilerplate >configuration > >On Fri, Sep 22, 2017 at 01:20:57PM +0200, Laszlo Ersek wrote: >> On 09/20/17 23:09, Leif Lindholm wrote: >> > On Wed, Sep 20, 2017 at 08:14:59PM +0200, Laszlo Ersek wrote: >> >> >> (2) Replacing a build define called FOOBAR with CONFIG_FOOBAR will >break >> >> all downstream build scripts. Is the CONFIG_ prefix a requirement? >> > >> > It was explicitly intended to break compatibility, to ensure we didn't >> > end up with things accidentally working until something unrelated >> > changed in the future. >> >> Interesting idea. I guess we could try to reach out to all of the >> "repeat builders" of OVMF. > >The proposal to drive the CONFIG options as Pcds would also be a >solution to this issue. > >> >> (3) I think PCDs should not be included in ConfigPkg DSC include file= s, >> >> even if several platforms set the same value. The set of libraries an= d >> >> driver modules commonly used for a given feature is mostly constant >> >> across platforms (and it is easy to extend, incrementally); but I don= 't >> >> think the same holds for PCDs. Especially if a user wants to change a >> >> PCD for one platform but not the other. Even if repeated settings for= a >> >> PCD worked (all on the same level of "specificity"), I'd find the res= ult >> >> confusing. >> > >> > Also a subject for discussion. >> > My intent was that if most of the open source platforms had an >> > override on the default of a particular Pcd, we could override it in >> > the config fragments without changing the .dec (and affecting >> > non-public ports). >> >> Right, that's great... >> >> > Individual platforms can still override (again). >> >> ... but this "again" part is what confuses me (assuming it would >> technically work). We'd have a PCD default in the .dec, then a setting >> in the central .dsc.inc that ultimately qualifies as a platform-level >> setting, and finally a setting in the actual platform .dsc, which *also* >> qualifies as a platform-level setting. IOW, one in the .dec, and two in >> the (final) .dsc. > >Yes. But I cannot think of another way of handling it, that does not >also mean stuffing a lot of boiler plate back into the platform-level >files. > >> I have no clue if this works, but even if it does, the priority could >> depend on the order of inclusion, which I find confusing. > >Oh, definitely. But also under complete control of the platform. > >Potentially, if this becomes some great success story, we will want to >extend the build command with a separate [includes] section to give >greater control over enforcing order. > >> Liming, Yonghong, can you guys please comment on this? > >Yes, please :) > >Regards, > >Leif