From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 024562095E533 for ; Mon, 25 Sep 2017 20:24:04 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP; 25 Sep 2017 20:27:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,439,1500966000"; d="scan'208";a="1199000504" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 25 Sep 2017 20:27:16 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 25 Sep 2017 20:27:16 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 25 Sep 2017 20:27:15 -0700 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.93]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 26 Sep 2017 11:27:13 +0800 From: "Gao, Liming" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic Thread-Index: AQHTNfwDj/FklLmUDkWPsB6Ov3KTTaLGgfZQ Date: Tue, 26 Sep 2017 03:27:13 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E15D601@SHSMSX152.ccr.corp.intel.com> References: <1506337584-9588-1-git-send-email-liming.gao@intel.com> <1506337584-9588-3-git-send-email-liming.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BA68B41@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA68B41@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 03:24:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray: There is no such key. OK, I will keep its usage to TO_START.=20 Thanks Liming > -----Original Message----- > From: Ni, Ruiyu > Sent: Monday, September 25, 2017 8:44 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Subject: RE: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF t= o match source code logic >=20 > Liming, > There is no keyword such as "SOMETIMES_TO_START"? > The DiskIo2 is indeed a TO_START protocol, but optional. >=20 > -----Original Message----- > From: Gao, Liming > Sent: Monday, September 25, 2017 7:06 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to ma= tch source code logic >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Ruiyu Ni > --- > FatPkg/EnhancedFatDxe/Fat.inf | 2 +- > FatPkg/FatPei/FatPei.inf | 10 +++++++--- > 2 files changed, 8 insertions(+), 4 deletions(-) >=20 > diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.in= f index e7044cd..686b371 100644 > --- a/FatPkg/EnhancedFatDxe/Fat.inf > +++ b/FatPkg/EnhancedFatDxe/Fat.inf > @@ -81,7 +81,7 @@ >=20 > [Protocols] > gEfiDiskIoProtocolGuid ## TO_START > - gEfiDiskIo2ProtocolGuid ## TO_START > + gEfiDiskIo2ProtocolGuid ## SOMETIMES_CONSUMES > gEfiBlockIoProtocolGuid ## TO_START > gEfiSimpleFileSystemProtocolGuid ## BY_START > gEfiUnicodeCollationProtocolGuid ## TO_START > diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index 27= 3f72d..c963429 100644 > --- a/FatPkg/FatPei/FatPei.inf > +++ b/FatPkg/FatPei/FatPei.inf > @@ -61,9 +61,13 @@ >=20 >=20 > [Ppis] > - gEfiPeiVirtualBlockIoPpiGuid ## SOMETIMES_CONSUMES PP= I_NOTIFY > - gEfiPeiVirtualBlockIo2PpiGuid ## SOMETIMES_CONSUMES PP= I_NOTIFY > - gEfiPeiDeviceRecoveryModulePpiGuid ## SOMETIMES_PRODUCES > + ## NOTIFY > + ## SOMETIMES_CONSUMES > + gEfiPeiVirtualBlockIoPpiGuid > + ## NOTIFY > + ## SOMETIMES_CONSUMES > + gEfiPeiVirtualBlockIo2PpiGuid > + gEfiPeiDeviceRecoveryModulePpiGuid ## PRODUCES >=20 >=20 > [FeaturePcd] > -- > 2.8.0.windows.1