From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the regression bug to build single module
Date: Wed, 27 Sep 2017 13:59:16 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E15E3FE@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <1506518547-12324-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Wednesday, September 27, 2017 9:22 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Fix the regression bug to build single module
>
> The bug is introduced by 1b8eca to collect single module's build time.
> Now the fix solution is copied from Platform build.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/build/build.py | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
> index dd65c66..13d8e50 100644
> --- a/BaseTools/Source/Python/build/build.py
> +++ b/BaseTools/Source/Python/build/build.py
> @@ -1830,10 +1830,22 @@ class Build():
> Pa = PlatformAutoGen(Wa, self.PlatformFile, BuildTarget, ToolChain, Arch)
> for Module in Pa.Platform.Modules:
> if self.ModuleFile.Dir == Module.Dir and self.ModuleFile.File == Module.File:
> Ma = ModuleAutoGen(Wa, Module, BuildTarget, ToolChain, Arch, self.PlatformFile)
> if Ma == None: continue
> + # Not to auto-gen for targets 'clean', 'cleanlib', 'cleanall', 'run', 'fds'
> + if self.Target not in ['clean', 'cleanlib', 'cleanall', 'run', 'fds']:
> + # for target which must generate AutoGen code and makefile
> + if not self.SkipAutoGen or self.Target == 'genc':
> + Ma.CreateCodeFile(True)
> + if self.Target == "genc":
> + continue
> +
> + if not self.SkipAutoGen or self.Target == 'genmake':
> + Ma.CreateMakeFile(True)
> + if self.Target == "genmake":
> + continue
> MaList.append(Ma)
> self.BuildModules.append(Ma)
> self.AutoGenTime += int(round((time.time() - AutoGenStart)))
> MakeStart = time.time()
> for Ma in self.BuildModules:
> --
> 2.6.1.windows.1
prev parent reply other threads:[~2017-09-27 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 13:22 [Patch] BaseTools: Fix the regression bug to build single module Yonghong Zhu
2017-09-27 13:59 ` Gao, Liming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E15E3FE@SHSMSX152.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox