From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0117020945BAC for ; Wed, 27 Sep 2017 06:56:05 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2017 06:59:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,445,1500966000"; d="scan'208";a="1199623340" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2017 06:59:18 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 06:59:18 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 06:59:18 -0700 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.93]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Wed, 27 Sep 2017 21:59:18 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Fix the regression bug to build single module Thread-Index: AQHTN5OzSBfi8rspGU+nI9rFzvnH96LIwnIA Date: Wed, 27 Sep 2017 13:59:16 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E15E3FE@SHSMSX152.ccr.corp.intel.com> References: <1506518547-12324-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1506518547-12324-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix the regression bug to build single module X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2017 13:56:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Zhu, Yonghong > Sent: Wednesday, September 27, 2017 9:22 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Fix the regression bug to build single module >=20 > The bug is introduced by 1b8eca to collect single module's build time. > Now the fix solution is copied from Platform build. >=20 > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Source/Python/build/build.py | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Py= thon/build/build.py > index dd65c66..13d8e50 100644 > --- a/BaseTools/Source/Python/build/build.py > +++ b/BaseTools/Source/Python/build/build.py > @@ -1830,10 +1830,22 @@ class Build(): > Pa =3D PlatformAutoGen(Wa, self.PlatformFile, BuildT= arget, ToolChain, Arch) > for Module in Pa.Platform.Modules: > if self.ModuleFile.Dir =3D=3D Module.Dir and sel= f.ModuleFile.File =3D=3D Module.File: > Ma =3D ModuleAutoGen(Wa, Module, BuildTarget= , ToolChain, Arch, self.PlatformFile) > if Ma =3D=3D None: continue > + # Not to auto-gen for targets 'clean', 'clea= nlib', 'cleanall', 'run', 'fds' > + if self.Target not in ['clean', 'cleanlib', = 'cleanall', 'run', 'fds']: > + # for target which must generate AutoGen= code and makefile > + if not self.SkipAutoGen or self.Target = =3D=3D 'genc': > + Ma.CreateCodeFile(True) > + if self.Target =3D=3D "genc": > + continue > + > + if not self.SkipAutoGen or self.Target = =3D=3D 'genmake': > + Ma.CreateMakeFile(True) > + if self.Target =3D=3D "genmake": > + continue > MaList.append(Ma) > self.BuildModules.append(Ma) > self.AutoGenTime +=3D int(round((time.time() - AutoG= enStart))) > MakeStart =3D time.time() > for Ma in self.BuildModules: > -- > 2.6.1.windows.1