public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Wei, David" <david.wei@intel.com>,
	"Yoon, Yeon Sil" <yeon.sil.yoon@intel.com>,
	"'edk2-devel@lists.01.org'" <edk2-devel@lists.01.org>
Cc: "Rytkonen, Teemu S" <teemu.s.rytkonen@intel.com>,
	"Loeppert, Anthony" <anthony.loeppert@intel.com>
Subject: Re: [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek
Date: Thu, 28 Sep 2017 02:09:56 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E15E8C4@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <89954A0B46707A448411A627AD4EEE3468F96141@SHSMSX101.ccr.corp.intel.com>

Yeonsil:
  Please send the patch by git send-email way. We don't use attachment for patch review. 

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Wei, David
> Sent: Thursday, September 28, 2017 9:50 AM
> To: Yoon, Yeon Sil <yeon.sil.yoon@intel.com>; 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org>
> Cc: Rytkonen, Teemu S <teemu.s.rytkonen@intel.com>; Loeppert, Anthony <anthony.loeppert@intel.com>
> Subject: [edk2] [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek
> 
> Hi Yeon Sil,
> 
> Only one comment: We need to add some code in _STA to make sure that this device is only reported to OS when it is actually present
> on the board. We will make some change to your patch as reference.
> 
> Thanks,
> David  Wei
> 
> Intel SSG/STO/UEFI BIOS
> 
> From: Yoon, Yeon Sil
> Sent: Thursday, September 28, 2017 6:32 AM
> To: 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org>
> Cc: Rytkonen, Teemu S <teemu.s.rytkonen@intel.com>; Loeppert, Anthony <anthony.loeppert@intel.com>; Wei, David
> <david.wei@intel.com>
> Subject: Review request for patch to enable SueCreek on Benson Glacier
> 
> Hello,
> 
> This is a patch to enable SueCreek module on Benson Glacier h/w.
> 
> Can you please review it?
> 
> Thanks!
> 
> Regards,
> Yeonsil
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-09-28  2:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  1:50 [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek Wei, David
2017-09-28  2:09 ` Gao, Liming [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-10-10  1:17 [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] " Guo, Mang
2017-10-10  1:25 ` Wei, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E15E8C4@SHSMSX152.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox