From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6FC5D21E1B773 for ; Wed, 27 Sep 2017 19:06:45 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2017 19:09:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,447,1500966000"; d="scan'208";a="317068818" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 27 Sep 2017 19:09:59 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 19:09:59 -0700 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.93]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Thu, 28 Sep 2017 10:09:56 +0800 From: "Gao, Liming" To: "Wei, David" , "Yoon, Yeon Sil" , "'edk2-devel@lists.01.org'" CC: "Rytkonen, Teemu S" , "Loeppert, Anthony" Thread-Topic: [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek Thread-Index: AdM3+zv+uN/9N0NoS6SM6BwE4c691QAA4DLg Date: Thu, 28 Sep 2017 02:09:56 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E15E8C4@SHSMSX152.ccr.corp.intel.com> References: <89954A0B46707A448411A627AD4EEE3468F96141@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <89954A0B46707A448411A627AD4EEE3468F96141@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 02:06:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yeonsil: Please send the patch by git send-email way. We don't use attachment for = patch review.=20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of We= i, David > Sent: Thursday, September 28, 2017 9:50 AM > To: Yoon, Yeon Sil ; 'edk2-devel@lists.01.org' <= edk2-devel@lists.01.org> > Cc: Rytkonen, Teemu S ; Loeppert, Anthony > Subject: [edk2] [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enabl= e SueCreek >=20 > Hi Yeon Sil, >=20 > Only one comment: We need to add some code in _STA to make sure that this= device is only reported to OS when it is actually present > on the board. We will make some change to your patch as reference. >=20 > Thanks, > David Wei >=20 > Intel SSG/STO/UEFI BIOS >=20 > From: Yoon, Yeon Sil > Sent: Thursday, September 28, 2017 6:32 AM > To: 'edk2-devel@lists.01.org' > Cc: Rytkonen, Teemu S ; Loeppert, Anthony ; Wei, David > > Subject: Review request for patch to enable SueCreek on Benson Glacier >=20 > Hello, >=20 > This is a patch to enable SueCreek module on Benson Glacier h/w. >=20 > Can you please review it? >=20 > Thanks! >=20 > Regards, > Yeonsil > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel