From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0504421E1B773 for ; Wed, 27 Sep 2017 20:53:24 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 27 Sep 2017 20:56:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,448,1500966000"; d="scan'208";a="156952318" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 27 Sep 2017 20:56:38 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 20:56:38 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 20:56:38 -0700 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.93]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Thu, 28 Sep 2017 11:56:37 +0800 From: "Gao, Liming" To: "Zeng, Star" , "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , "Dong, Eric" Thread-Topic: [edk2] [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift Thread-Index: AQHTMqVvfRYIGB5gek+WQ5fVcfjZb6LEooeAgAUTR+A= Date: Thu, 28 Sep 2017 03:56:37 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E15EAAA@SHSMSX152.ccr.corp.intel.com> References: <20170921064617.2628-1-hao.a.wu@intel.com> <20170921064617.2628-7-hao.a.wu@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B97970A@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B97970A@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 03:53:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star: Crc32 change is not required . I just gives my comment on it. So, there is= no consistent issue here. We can keep this patch.=20 Thanks Liming >-----Original Message----- >From: Zeng, Star >Sent: Monday, September 25, 2017 2:25 PM >To: Wu, Hao A ; edk2-devel@lists.01.org >Cc: Wu, Hao A ; Dong, Eric ; Gao, >Liming ; Zeng, Star >Subject: RE: [edk2] [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix >possible out of range left shift > >I prefer to have the code consistent between this patch with [PATCH v2 5/6= ] >MdeModulePkg/Crc32: Fix possible out of range left shift. > >Both to use (UINT32) typecast or 1U. > >Liming, Do you have any comment? > > >Thanks, >Star >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Hao >Wu >Sent: Thursday, September 21, 2017 2:46 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Dong, Eric ; >Zeng, Star >Subject: [edk2] [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: Fix >possible out of range left shift > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D699 > >Within function AhciModeInitialization(), left shift operations of 'BIT0' >in the following statements: >"if ((PortImplementBitMap & (BIT0 << Port)) !=3D 0) {" > >will incur possible out of range left shift when Port is 31, since >"1 << 31" is possible to exceed the range of type 'int' (signed). > >According to the C11 spec, Section 6.5.7: >> 4 The result of E1 << E2 is E1 left-shifted E2 bit positions; vacated >> bits are filled with zeros. If E1 has an unsigned type, the value >> of the result is E1 * 2^E2 , reduced modulo one more than the >> maximum value representable in the result type. If E1 has a signed >> type and nonnegative value, and E1 * 2^E2 is representable in the >> result type, then that is the resulting value; otherwise, the >> behavior is undefined. > >This commit explicitly cast 'BIT0' with UINT32 to resolve this issue. > >Cc: Steven Shi >Cc: Star Zeng >Cc: Eric Dong >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Hao Wu >--- > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c >b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c >index b954de8101..e6de5d65bc 100644 >--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c >+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c >@@ -1,7 +1,7 @@ > /** @file > The file for AHCI mode of ATA host controller. > >- Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.
>+ Copyright (c) 2010 - 2017, Intel Corporation. All rights >+ reserved.
> (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the B= SD >License @@ -2314,7 +2314,7 @@ AhciModeInitialization ( > } > > for (Port =3D 0; Port < EFI_AHCI_MAX_PORTS; Port ++) { >- if ((PortImplementBitMap & (BIT0 << Port)) !=3D 0) { >+ if ((PortImplementBitMap & (((UINT32)BIT0) << Port)) !=3D 0) { > // > // According to AHCI spec, MaxPortNumber should be equal or greater >than the number of implemented ports. > // >-- >2.12.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel