From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C6DD92095E537 for ; Mon, 9 Oct 2017 01:11:47 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2017 01:15:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,499,1500966000"; d="scan'208";a="160475970" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 09 Oct 2017 01:15:14 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Oct 2017 01:15:13 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Oct 2017 01:15:13 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Mon, 9 Oct 2017 16:15:11 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Fix a bug to use module's Name attribute as compare Thread-Index: AQHTQNac6tqDh4hKu0mx85+mKk05xKLbK8OQ Date: Mon, 9 Oct 2017 08:15:10 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E168AD4@SHSMSX104.ccr.corp.intel.com> References: <1507536854-18804-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1507536854-18804-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix a bug to use module's Name attribute as compare X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 08:11:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Monday, October 09, 2017 4:14 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix a bug to use module's Name attribute as >compare > >Fix a bug to use module's Name attribute as compare for single module >build. ModuleFile.File can't be used to compare INF file, because it >is the relative path. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/build.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 13d8e50..a3bb632 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -1827,11 +1827,11 @@ class Build(): > for Arch in Wa.ArchList: > AutoGenStart =3D time.time() > GlobalData.gGlobalDefines['ARCH'] =3D Arch > Pa =3D PlatformAutoGen(Wa, self.PlatformFile, BuildTa= rget, ToolChain, >Arch) > for Module in Pa.Platform.Modules: >- if self.ModuleFile.Dir =3D=3D Module.Dir and self= .ModuleFile.File =3D=3D >Module.File: >+ if self.ModuleFile.Dir =3D=3D Module.Dir and self= .ModuleFile.Name >=3D=3D Module.Name: > Ma =3D ModuleAutoGen(Wa, Module, BuildTarget,= ToolChain, >Arch, self.PlatformFile) > if Ma =3D=3D None: continue > # Not to auto-gen for targets 'clean', 'clean= lib', 'cleanall', 'run', >'fds' > if self.Target not in ['clean', 'cleanlib', '= cleanall', 'run', 'fds']: > # for target which must generate AutoGen = code and makefile >-- >2.6.1.windows.1