From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0111D202E6180 for ; Mon, 16 Oct 2017 17:50:13 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 16 Oct 2017 17:53:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,389,1503385200"; d="scan'208";a="1025851451" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 16 Oct 2017 17:53:48 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 17:53:48 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 17:53:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 17 Oct 2017 08:53:46 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" CC: "sudeep.holla@arm.com" Thread-Topic: [edk2] [PATCH edk2-platforms] Platform/ARM: remove ReportStatusCodeLib resolutions Thread-Index: AQHTRqlBi+64kNBAm0K0WFhXCoaTM6LnNvgg Date: Tue, 17 Oct 2017 00:53:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E16C97C@SHSMSX104.ccr.corp.intel.com> References: <20171016180347.22930-1-ard.biesheuvel@linaro.org> In-Reply-To: <20171016180347.22930-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH edk2-platforms] Platform/ARM: remove ReportStatusCodeLib resolutions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 00:50:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard: MdeModulePkg\Library\RuntimeDxeReportStatusCodeLib\RuntimeDxeReportStatus= CodeLib.inf is designed for Runtime driver. If you require StatusCode at ru= ntime, you can use this library instance.=20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ar= d Biesheuvel > Sent: Tuesday, October 17, 2017 2:04 AM > To: edk2-devel@lists.01.org; leif.lindholm@linaro.org > Cc: Ard Biesheuvel ; sudeep.holla@arm.com > Subject: [edk2] [PATCH edk2-platforms] Platform/ARM: remove ReportStatusC= odeLib resolutions >=20 > The generic ResetSystemRuntimeDxe may invoke ReportStatusCodeLib, and > this may happen at runtime. If the chosen resolution is not suitable > for runtime, this will result in a crash. >=20 > Given that we don't actually use status codes, let's just switch to > the NULL instance for all modules and be done with it. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/= VExpressPkg/ArmVExpress.dsc.inc > index 8bcb84869c84..b758c58c9872 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -153,7 +153,7 @@ > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in= f > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customi= zedDisplayLib.inf >=20 > - ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep= ortStatusCodeLib.inf > + ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseRep= ortStatusCodeLibNull.inf >=20 > [LibraryClasses.common.SEC] > ArmPlatformSecExtraActionLib|ArmPlatformPkg/Library/DebugSecExtraActio= nLib/DebugSecExtraActionLib.inf > @@ -182,7 +182,6 @@ > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAll= ocationLib.inf > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.i= nf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLi= b.inf > - OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oem= HookStatusCodeLibNull.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BaseP= eCoffGetEntryPointLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiE= xtractGuidedSectionLib.inf >=20 > @@ -195,7 +194,6 @@ > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAll= ocationLib.inf > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLi= b.inf > - OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/Oem= HookStatusCodeLibNull.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BaseP= eCoffGetEntryPointLib.inf > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/Pei= ResourcePublicationLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiE= xtractGuidedSectionLib.inf > @@ -358,8 +356,6 @@ > # DEBUG_ERROR 0x80000000 // Error > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F >=20 > - gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > - > gEmbeddedTokenSpaceGuid.PcdEmbeddedAutomaticBootCommand|"" > gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07 > gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000 > -- > 2.11.0 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel