From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC589202E60E3 for ; Wed, 18 Oct 2017 00:58:10 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2017 01:01:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,395,1503385200"; d="scan'208";a="161776132" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 18 Oct 2017 01:01:45 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 01:01:45 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 01:01:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Wed, 18 Oct 2017 16:01:43 +0800 From: "Gao, Liming" To: Laszlo Ersek , edk2-devel-01 CC: Thomas Huth , "Zhu, Yonghong" Thread-Topic: [PATCH] BaseTools/BuildEnv: override "set -C" (noclobber) in sourcing shell env Thread-Index: AQHTR4yu74xvlxxUZ0WEPrRkByNIgaLpP40Q Date: Wed, 18 Oct 2017 08:01:43 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E16D542@SHSMSX104.ccr.corp.intel.com> References: <20171017211234.13730-1-lersek@redhat.com> In-Reply-To: <20171017211234.13730-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools/BuildEnv: override "set -C" (noclobber) in sourcing shell env X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 07:58:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Laszlo Ersek [mailto:lersek@redhat.com] >Sent: Wednesday, October 18, 2017 5:13 AM >To: edk2-devel-01 >Cc: Gao, Liming ; Thomas Huth ; >Zhu, Yonghong >Subject: [PATCH] BaseTools/BuildEnv: override "set -C" (noclobber) in >sourcing shell env > >The BuildEnv utility is sourced (executed by the user's interactive shell) >when the user sets up the build session. Some users like to set -C >(noclobber) for some additional safety in their shells, which trips up >BuildEnv. Update the redirection operator so that it overrides noclobber. > >Cc: Liming Gao >Cc: Thomas Huth >Cc: Yonghong Zhu >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Laszlo Ersek >--- > >Notes: > Repo: https://github.com/lersek/edk2.git > Branch: buildenv_clobber > > BaseTools/BuildEnv | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv >index f74881111c8e..ff0c5115a5e1 100755 >--- a/BaseTools/BuildEnv >+++ b/BaseTools/BuildEnv >@@ -90,7 +90,7 @@ StoreCurrentConfiguration() { > # > OUTPUT_FILE=3D$CONF_PATH/BuildEnv.sh > #echo Storing current configuration into $OUTPUT_FILE >- echo "# Auto-generated by ${BASH_SOURCE[0]}" > $OUTPUT_FILE >+ echo "# Auto-generated by ${BASH_SOURCE[0]}" >| $OUTPUT_FILE > GenerateShellCodeToSetVariable WORKSPACE $OUTPUT_FILE > GenerateShellCodeToSetVariable EDK_TOOLS_PATH $OUTPUT_FILE > GenerateShellCodeToUpdatePath $OUTPUT_FILE >-- >2.14.1.3.gb7cf6e02401b