From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 65FA121FCA276 for ; Wed, 1 Nov 2017 08:09:49 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2017 08:13:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,329,1505804400"; d="scan'208";a="170550815" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 01 Nov 2017 08:13:41 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Nov 2017 08:13:41 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Nov 2017 08:13:41 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Wed, 1 Nov 2017 23:13:39 +0800 From: "Gao, Liming" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Zhu, Yonghong" CC: "daniel.thompson@linaro.org" Thread-Topic: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources Thread-Index: AQHTUyJZ4tctqctTA0GI/gRci56/JaL/obNQ Date: Wed, 1 Nov 2017 15:13:39 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E176A26@SHSMSX104.ccr.corp.intel.com> References: <20171101150125.13679-1-ard.biesheuvel@linaro.org> In-Reply-To: <20171101150125.13679-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 15:09:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Wednesday, November 1, 2017 11:01 PM > To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming ; Zhu, Yonghong > > Cc: daniel.thompson@linaro.org; Ard Biesheuvel > Subject: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for= .aslc sources >=20 > Commit 1894a7c64c0a ("BaseTools/tools_def AARCH64 ARM: disable PIE > linking") works around an issue that was caught due to the fact that > PIE linking produces broken .acpi files. However, v2 of that fix > inadvertently only applied the workaround to the normal linker command > line, and not to the ASLD one, so the issue still persists. >=20 > So add the missing -no-pie options for ASLD on ARM and AARCH64. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def= .template > index 98df0ffc9294..aebd7d558633 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -4498,8 +4498,8 @@ DEFINE GCC5_ARM_DLINK_FLAGS =3D DEF(GCC49_= ARM_DLINK_FLAGS) -no-pie > DEFINE GCC5_ARM_DLINK2_FLAGS =3D DEF(GCC49_ARM_DLINK2_FLAGS) -Wn= o-error > DEFINE GCC5_AARCH64_DLINK_FLAGS =3D DEF(GCC49_AARCH64_DLINK_FLAGS) = -no-pie > DEFINE GCC5_AARCH64_DLINK2_FLAGS =3D DEF(GCC49_AARCH64_DLINK2_FLAGS)= -Wno-error > -DEFINE GCC5_ARM_ASLDLINK_FLAGS =3D DEF(GCC49_ARM_ASLDLINK_FLAGS) > -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS =3D DEF(GCC49_AARCH64_ASLDLINK_FLAG= S) > +DEFINE GCC5_ARM_ASLDLINK_FLAGS =3D DEF(GCC49_ARM_ASLDLINK_FLAGS) -= no-pie > +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS =3D DEF(GCC49_AARCH64_ASLDLINK_FLAG= S) -no-pie >=20 > ########################################################################= ############ > # > -- > 2.11.0