From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A6C1A2034D812 for ; Mon, 6 Nov 2017 23:53:37 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2017 23:57:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,357,1505804400"; d="scan'208";a="4367187" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 06 Nov 2017 23:57:35 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 6 Nov 2017 23:57:35 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Tue, 7 Nov 2017 15:57:33 +0800 From: "Gao, Liming" To: "Yao, Jiewen" , "Song, BinX" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning Thread-Index: AdNXiiC05LEXwRtuTPKvO902HothWgAAIQPAAAAbz3AAABHbcAAAflVQAAPAqJA= Date: Tue, 7 Nov 2017 07:57:32 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1795A8@SHSMSX104.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF1025BBD42@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA1299B@shsmsx102.ccr.corp.intel.com> <559D2DF22BC9A3468B4FA1AA547F0EF1025BBE33@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA129D3@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA12A36@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AA12A36@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 07:53:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen: We plan to enable this option in new VS tool chain VS2017. So, we can kee= p DSC without the change, and enable this option after VS2017 tool chain is= added.=20 Thanks Liming >-----Original Message----- >From: Yao, Jiewen >Sent: Tuesday, November 07, 2017 2:00 PM >To: Yao, Jiewen ; Song, BinX ; >edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning > >Sorry, let me clarify, if we believe C4255 can help catch more problem, an= d we >fixed all problem, why not enable it in BaseTool directly. > > > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yao, >> Jiewen >> Sent: Tuesday, November 7, 2017 1:44 PM >> To: Song, BinX ; edk2-devel@lists.01.org >> Cc: Gao, Liming >> Subject: Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT >C4255 >> warning >> >> Yes, I suggest we fix it. >> >> > -----Original Message----- >> > From: Song, BinX >> > Sent: Tuesday, November 7, 2017 1:43 PM >> > To: Yao, Jiewen ; edk2-devel@lists.01.org >> > Cc: Gao, Liming >> > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 >warning >> > >> > Hi Jiewen, >> > >> > Do you mean we fix the problem after enable MSFT C4255 warning? >> > If yes, I have fix them in related patch, such as MdeModulePkg. >> > >> > Best Regards, >> > Bell Song >> > >> > >> > > -----Original Message----- >> > > From: Yao, Jiewen >> > > Sent: Tuesday, November 7, 2017 1:39 PM >> > > To: Song, BinX ; edk2-devel@lists.01.org >> > > Cc: Gao, Liming >> > > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 >> > > warning >> > > >> > > Hi >> > > I suggest we fix the problem. >> > > >> > > > -----Original Message----- >> > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behal= f >Of >> > > Song, >> > > > BinX >> > > > Sent: Tuesday, November 7, 2017 1:35 PM >> > > > To: edk2-devel@lists.01.org >> > > > Cc: Gao, Liming >> > > > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT >C4255 >> > > warning >> > > > >> > > > Enable MSFT C4255 warning >> > > > >> > > > From MSDN: >> > > > Compiler Warning (level 4) C4255 >> > > > function' : no function prototype given: converting '()' to '(void= )' >> > > > The compiler did not find an explicit list of arguments to a funct= ion. >> > > > This warning is for the C compiler only. >> > > > >> > > > Cc: Liming Gao >> > > > Contributed-under: TianoCore Contribution Agreement 1.1 >> > > > Signed-off-by: Bell Song >> > > > --- >> > > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 + >> > > > 1 file changed, 1 insertion(+) >> > > > >> > > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc >> > > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc >> > > > index 6496dad..4b4d5b2 100644 >> > > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc >> > > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc >> > > > @@ -95,3 +95,4 @@ >> > > > >> > > > [BuildOptions] >> > > > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES >> > > > + MSFT:*_*_*_CC_FLAGS =3D /we4255 >> > > > -- >> > > > 2.10.2.windows.1 >> > > > >> > > > _______________________________________________ >> > > > edk2-devel mailing list >> > > > edk2-devel@lists.01.org >> > > > https://lists.01.org/mailman/listinfo/edk2-devel >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel