public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Fix the bug to collect source files per build rule family
Date: Tue, 14 Nov 2017 09:58:48 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E17DCB2@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1510638762-6604-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, November 14, 2017 1:53 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Fix the bug to collect source files per build rule
>family
>
>when collect source files list we should also consider build rule
>family.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
>b/BaseTools/Source/Python/AutoGen/AutoGen.py
>index b3e7089..008ad8e 100644
>--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
>+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
>@@ -3265,17 +3265,17 @@ class ModuleAutoGen(AutoGen):
>                 # match tool chain
>                 if F.TagName not in ("", "*", self.ToolChain):
>                     EdkLogger.debug(EdkLogger.DEBUG_9, "The toolchain [%s] for
>processing file [%s] is found, "
>                                     "but [%s] is needed" % (F.TagName, str(F), self.ToolChain))
>                     continue
>-                # match tool chain family
>-                if F.ToolChainFamily not in ("", "*", self.ToolChainFamily):
>+                # match tool chain family or build rule family
>+                if F.ToolChainFamily not in ("", "*", self.ToolChainFamily,
>self.BuildRuleFamily):
>                     EdkLogger.debug(
>                                 EdkLogger.DEBUG_0,
>                                 "The file [%s] must be built by tools of [%s], " \
>-                                "but current toolchain family is [%s]" \
>-                                    % (str(F), F.ToolChainFamily, self.ToolChainFamily))
>+                                "but current toolchain family is [%s], buildrule family is [%s]"
>\
>+                                    % (str(F), F.ToolChainFamily, self.ToolChainFamily,
>self.BuildRuleFamily))
>                     continue
>
>                 # add the file path into search path list for file including
>                 if F.Dir not in self.IncludePathList and self.AutoGenVersion >=
>0x00010005:
>                     self.IncludePathList.insert(0, F.Dir)
>--
>2.6.1.windows.1



  reply	other threads:[~2017-11-14  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14  5:52 [Patch] BaseTools: Fix the bug to collect source files per build rule family Yonghong Zhu
2017-11-14  9:58 ` Gao, Liming [this message]
2017-11-15 16:23 ` Laszlo Ersek
2017-11-16  0:02   ` Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E17DCB2@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox