From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 202512034711C for ; Mon, 20 Nov 2017 01:20:58 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2017 01:25:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,426,1505804400"; d="scan'208";a="1246315654" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 20 Nov 2017 01:25:12 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Nov 2017 01:25:12 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Nov 2017 01:25:11 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Mon, 20 Nov 2017 17:25:10 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Fix a bug for single module build with GenC/GenMake option Thread-Index: AQHTX1jydlYpILITxU6bgjSi6eL4eqMdBDAg Date: Mon, 20 Nov 2017 09:25:09 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E180A29@SHSMSX104.ccr.corp.intel.com> References: <1510891352-7856-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1510891352-7856-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix a bug for single module build with GenC/GenMake option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2017 09:20:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, November 17, 2017 12:03 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: Fix a bug for single module build with >GenC/GenMake option > >when build a single module with GenC/GenMake option, currently it will >direct return after create Autogen code files, then it cause MaList is >empty, which cause an incorrect error message is reported. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/build/build.py | 5 ----- > 1 file changed, 5 deletions(-) > >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 4f73bba..53f1245 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -1835,17 +1835,12 @@ class Build(): > # Not to auto-gen for targets 'clean', 'clean= lib', 'cleanall', 'run', >'fds' > if self.Target not in ['clean', 'cleanlib', '= cleanall', 'run', 'fds']: > # for target which must generate AutoGen = code and makefile > if not self.SkipAutoGen or self.Target = =3D=3D 'genc': > Ma.CreateCodeFile(True) >- if self.Target =3D=3D "genc": >- continue >- > if not self.SkipAutoGen or self.Target = =3D=3D 'genmake': > Ma.CreateMakeFile(True) >- if self.Target =3D=3D "genmake": >- continue > MaList.append(Ma) > self.BuildModules.append(Ma) > self.AutoGenTime +=3D int(round((time.time() - AutoGe= nStart))) > MakeStart =3D time.time() > for Ma in self.BuildModules: >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel