From: "Gao, Liming" <liming.gao@intel.com>
To: Pete Batard <pete@akeo.ie>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 3/6] MdePkg/Library/BaseLib: Enable VS2017/ARM builds
Date: Mon, 4 Dec 2017 15:40:22 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E189CF7@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20171204131205.11304-4-pete@akeo.ie>
Pete:
Why override compiler option /GL- here?
> -----Original Message-----
> From: Pete Batard [mailto:pete@akeo.ie]
> Sent: Monday, December 4, 2017 9:12 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH 3/6] MdePkg/Library/BaseLib: Enable VS2017/ARM builds
>
> Most of the RVCT assembly can be reused as is for MSFT except
> for CpuBreakpoint.asm, which we need to force to Arm mode.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
> MdePkg/Library/BaseLib/Arm/CpuBreakpoint.asm | 5 ++++-
> MdePkg/Library/BaseLib/BaseLib.inf | 19 ++++++++++++++++---
> 2 files changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/MdePkg/Library/BaseLib/Arm/CpuBreakpoint.asm b/MdePkg/Library/BaseLib/Arm/CpuBreakpoint.asm
> index 8a8065159bf2..2e508d6f1ad8 100644
> --- a/MdePkg/Library/BaseLib/Arm/CpuBreakpoint.asm
> +++ b/MdePkg/Library/BaseLib/Arm/CpuBreakpoint.asm
> @@ -16,7 +16,10 @@
>
> EXPORT CpuBreakpoint
>
> - AREA Cpu_Breakpoint, CODE, READONLY
> +; Force ARM mode for this section, as MSFT assembler defaults to THUMB
> + AREA Cpu_Breakpoint, CODE, READONLY, ARM
> +
> + ARM
>
> ;/**
> ; Generates a breakpoint on the CPU.
> diff --git a/MdePkg/Library/BaseLib/BaseLib.inf b/MdePkg/Library/BaseLib/BaseLib.inf
> index 320ac457ea3d..4337a125d516 100644
> --- a/MdePkg/Library/BaseLib/BaseLib.inf
> +++ b/MdePkg/Library/BaseLib/BaseLib.inf
> @@ -821,8 +821,9 @@ [Sources.EBC]
> [Sources.ARM]
> Arm/InternalSwitchStack.c
> Arm/Unaligned.c
> - Math64.c | RVCT
> -
> + Math64.c | RVCT
> + Math64.c | MSFT
> +
> Arm/SwitchStack.asm | RVCT
> Arm/SetJumpLongJump.asm | RVCT
> Arm/DisableInterrupts.asm | RVCT
> @@ -831,7 +832,16 @@ [Sources.ARM]
> Arm/CpuPause.asm | RVCT
> Arm/CpuBreakpoint.asm | RVCT
> Arm/MemoryFence.asm | RVCT
> -
> +
> + Arm/SwitchStack.asm | MSFT
> + Arm/SetJumpLongJump.asm | MSFT
> + Arm/DisableInterrupts.asm | MSFT
> + Arm/EnableInterrupts.asm | MSFT
> + Arm/GetInterruptsState.asm | MSFT
> + Arm/CpuPause.asm | MSFT
> + Arm/CpuBreakpoint.asm | MSFT
> + Arm/MemoryFence.asm | MSFT
> +
> Arm/Math64.S | GCC
> Arm/SwitchStack.S | GCC
> Arm/EnableInterrupts.S | GCC
> @@ -870,3 +880,6 @@ [Pcd]
>
> [FeaturePcd]
> gEfiMdePkgTokenSpaceGuid.PcdVerifyNodeInList ## CONSUMES
> +
> +[BuildOptions]
> + MSFT:*_*_ARM_CC_FLAGS = /GL-
> --
> 2.9.3.windows.2
next prev parent reply other threads:[~2017-12-04 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 13:11 [PATCH 0/6] Add ARM support for VS2017 Pete Batard
2017-12-04 13:12 ` [PATCH 1/6] MdePkg: Disable some Level 4 warnings for VS2017/ARM Pete Batard
2017-12-04 15:36 ` Gao, Liming
2017-12-04 17:42 ` Pete Batard
2017-12-04 13:12 ` [PATCH 2/6] MdePkg/Library/BaseStackCheckLib: Add Null handler " Pete Batard
2017-12-04 13:12 ` [PATCH 3/6] MdePkg/Library/BaseLib: Enable VS2017/ARM builds Pete Batard
2017-12-04 15:40 ` Gao, Liming [this message]
2017-12-04 17:43 ` Pete Batard
2017-12-04 13:12 ` [PATCH 4/6] ArmPkg/Library/CompilerIntrinsicsLib: " Pete Batard
2017-12-04 13:12 ` [PATCH 5/6] MdePkg/Include: Add VA list support for VS2017/ARM Pete Batard
2017-12-04 13:12 ` [PATCH 6/6] BaseTools/Conf: Add VS2017/ARM support Pete Batard
2017-12-04 15:48 ` Gao, Liming
2017-12-04 17:43 ` Pete Batard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E189CF7@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox