public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Add object_files.lst as dependency of lib target
Date: Wed, 6 Dec 2017 02:00:19 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E18AE7F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1512525097-4416-1-git-send-email-yonghong.zhu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Wednesday, December 06, 2017 9:52 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Add object_files.lst as dependency of lib target
>
>Seems object_files.lst is not added as dependency of lib target, this
>patch update BaseTools to generate Makefile with this dependency.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/AutoGen/GenMake.py | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py
>b/BaseTools/Source/Python/AutoGen/GenMake.py
>index 0f3ddd5..410ad59 100644
>--- a/BaseTools/Source/Python/AutoGen/GenMake.py
>+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
>@@ -862,10 +862,12 @@ cleanlib:
>                         Deps.append(NewFile)
>
>                 # Use file list macro as dependency
>                 if T.GenFileListMacro:
>                     Deps.append("$(%s)" % T.FileListMacro)
>+                    if Type in [TAB_OBJECT_FILE, TAB_STATIC_LIBRARY]:
>+                        Deps.append("$(%s)" % T.ListFileMacro)
>
>                 TargetDict = {
>                     "target"    :   self.PlaceMacro(T.Target.Path, self.Macros),
>                     "cmd"       :   "\n\t".join(T.Commands),
>                     "deps"      :   Deps
>--
>2.6.1.windows.1



      reply	other threads:[~2017-12-06  1:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06  1:51 [Patch] BaseTools: Add object_files.lst as dependency of lib target Yonghong Zhu
2017-12-06  2:00 ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E18AE7F@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox