From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 80999220FB319 for ; Tue, 5 Dec 2017 17:55:51 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2017 18:00:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,366,1508828400"; d="scan'208";a="9936524" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 05 Dec 2017 18:00:22 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 5 Dec 2017 18:00:22 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 5 Dec 2017 18:00:21 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Wed, 6 Dec 2017 10:00:20 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Add object_files.lst as dependency of lib target Thread-Index: AQHTbjTEByT0ptjsz0yL01aU1jrnZ6M1j4OA Date: Wed, 6 Dec 2017 02:00:19 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E18AE7F@SHSMSX104.ccr.corp.intel.com> References: <1512525097-4416-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1512525097-4416-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Add object_files.lst as dependency of lib target X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 01:55:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Zhu, Yonghong >Sent: Wednesday, December 06, 2017 9:52 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Add object_files.lst as dependency of lib targ= et > >Seems object_files.lst is not added as dependency of lib target, this >patch update BaseTools to generate Makefile with this dependency. > >Cc: Liming Gao >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Yonghong Zhu >--- > BaseTools/Source/Python/AutoGen/GenMake.py | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py >b/BaseTools/Source/Python/AutoGen/GenMake.py >index 0f3ddd5..410ad59 100644 >--- a/BaseTools/Source/Python/AutoGen/GenMake.py >+++ b/BaseTools/Source/Python/AutoGen/GenMake.py >@@ -862,10 +862,12 @@ cleanlib: > Deps.append(NewFile) > > # Use file list macro as dependency > if T.GenFileListMacro: > Deps.append("$(%s)" % T.FileListMacro) >+ if Type in [TAB_OBJECT_FILE, TAB_STATIC_LIBRARY]: >+ Deps.append("$(%s)" % T.ListFileMacro) > > TargetDict =3D { > "target" : self.PlaceMacro(T.Target.Path, self.M= acros), > "cmd" : "\n\t".join(T.Commands), > "deps" : Deps >-- >2.6.1.windows.1