From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DC0C2218E923 for ; Wed, 6 Dec 2017 19:39:33 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 19:44:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,370,1508828400"; d="scan'208";a="16147842" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 06 Dec 2017 19:44:05 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 19:44:05 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Thu, 7 Dec 2017 11:44:03 +0800 From: "Gao, Liming" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX in nasm code Thread-Index: AQHTbwVuLoExsxeYF0+HjoIdAwm896M2qICAgACGYBD//3wIAIAAkfPQ Date: Thu, 7 Dec 2017 03:44:03 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E18BAB3@SHSMSX104.ccr.corp.intel.com> References: <1512614710-9956-1-git-send-email-liming.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA3C710@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E18BA1A@SHSMSX104.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AA3C796@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AA3C796@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing ASM_PFX in nasm code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 03:39:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable XCODE5 tool chain reports them. For this change, I think build pass is eno= ugh.=20 I send another patch to fix the missing ASM_PFX in SmmCpuFeaturesLib. Thanks Liming >-----Original Message----- >From: Yao, Jiewen >Sent: Thursday, December 07, 2017 11:00 AM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Dong, Eric >Subject: RE: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing >ASM_PFX in nasm code > >I think so. > >May I know how this is found? And how this is validated? > >I think we need build the whole package to trigger all the failure, and fi= x all. > >Thank you >Yao Jiewen > > >> -----Original Message----- >> From: Gao, Liming >> Sent: Thursday, December 7, 2017 10:53 AM >> To: Yao, Jiewen ; edk2-devel@lists.01.org >> Cc: Dong, Eric >> Subject: RE: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing >> ASM_PFX in nasm code >> >> Do you mean SmmCpuFeaturesLib also has the similar issue? If yes, I will >provide >> the patch to fix it. >> >> >-----Original Message----- >> >From: Yao, Jiewen >> >Sent: Thursday, December 07, 2017 10:52 AM >> >To: Gao, Liming ; edk2-devel@lists.01.org >> >Cc: Dong, Eric >> >Subject: RE: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the >missing >> >ASM_PFX in nasm code >> > >> >Hi Liming >> >Reviewed-by: Jiewen.yao@intel.com >> > >> >BTW: Do you think we also need update SmmCpuFeaturesLib ? >> > >> >Thank you >> >Yao Jiewen >> > >> > >> >> -----Original Message----- >> >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf >Of >> >Liming >> >> Gao >> >> Sent: Thursday, December 7, 2017 10:45 AM >> >> To: edk2-devel@lists.01.org >> >> Cc: Dong, Eric >> >> Subject: [edk2] [Patch] UefiCpuPkg: PiSmmCpuDxeSmm Add the missing >> >> ASM_PFX in nasm code >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Liming Gao >> >> Cc: Eric Dong >> >> --- >> >> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 10 +++++----- >> >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> >> >> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm >> >> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm >> >> index c3c094f..dc56dc7 100644 >> >> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm >> >> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm >> >> @@ -1,5 +1,5 @@ >> >> ;-------------------------------------------------------------------= ----------- ; >> >> -; Copyright (c) 2016, Intel Corporation. All rights reserved.
>> >> +; Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.=
>> >> ; This program and the accompanying materials >> >> ; are licensed and made available under the terms and conditions of = the >BSD >> >> License >> >> ; which accompanies this distribution. The full text of the license= may be >> >found >> >> at >> >> @@ -184,15 +184,15 @@ _SmiHandler: >> >> add rsp, -0x20 >> >> >> >> mov rcx, rbx >> >> - mov rax, CpuSmmDebugEntry >> >> + mov rax, ASM_PFX(CpuSmmDebugEntry) >> >> call rax >> >> >> >> mov rcx, rbx >> >> - mov rax, SmiRendezvous ; rax <- absolute addr of >> >> SmiRedezvous >> >> + mov rax, ASM_PFX(SmiRendezvous) ; rax <- absolute addr of >> >> SmiRedezvous >> >> call rax >> >> >> >> mov rcx, rbx >> >> - mov rax, CpuSmmDebugExit >> >> + mov rax, ASM_PFX(CpuSmmDebugExit) >> >> call rax >> >> >> >> add rsp, 0x20 >> >> @@ -220,5 +220,5 @@ _SmiHandler: >> >> .1: >> >> rsm >> >> >> >> -gcSmiHandlerSize DW $ - _SmiEntryPoint >> >> +ASM_PFX(gcSmiHandlerSize) DW $ - _SmiEntryPoint >> >> >> >> -- >> >> 2.8.0.windows.1 >> >> >> >> _______________________________________________ >> >> edk2-devel mailing list >> >> edk2-devel@lists.01.org >> >> https://lists.01.org/mailman/listinfo/edk2-devel