From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 1/2] MdePkg MmCommunication.h: Follow PI spec to update EFI_MM_COMMUNICATE
Date: Thu, 7 Dec 2017 14:59:14 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E18C0F3@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1512551879-14388-2-git-send-email-star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, December 6, 2017 5:18 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [PATCH 1/2] MdePkg MmCommunication.h: Follow PI spec to update EFI_MM_COMMUNICATE
>
> Follow PI spec (>= 1.5) to add new return status code description
> and make CommSize OPTIONAL.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdePkg/Include/Protocol/MmCommunication.h | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Include/Protocol/MmCommunication.h b/MdePkg/Include/Protocol/MmCommunication.h
> index 16450e3445b0..774686ba3e7f 100644
> --- a/MdePkg/Include/Protocol/MmCommunication.h
> +++ b/MdePkg/Include/Protocol/MmCommunication.h
> @@ -55,18 +55,28 @@ typedef struct _EFI_MM_COMMUNICATION_PROTOCOL EFI_MM_COMMUNICATION_PROTOCOL;
>
> @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL instance.
> @param[in] CommBuffer A pointer to the buffer to convey into MMRAM.
> - @param[in] CommSize The size of the data buffer being passed in.On exit, the size of data
> + @param[in] CommSize The size of the data buffer being passed in. On exit, the size of data
> being returned. Zero if the handler does not wish to reply with any data.
> + This parameter is optional and may be NULL.
>
> @retval EFI_SUCCESS The message was successfully posted.
> @retval EFI_INVALID_PARAMETER The CommBuffer was NULL.
> + @retval EFI_BAD_BUFFER_SIZE The buffer is too large for the MM implementation.
> + If this error is returned, the MessageLength field
> + in the CommBuffer header or the integer pointed by
> + CommSize, are updated to reflect the maximum payload
> + size the implementation can accommodate.
> + @retval EFI_ACCESS_DENIED The CommunicateBuffer parameter or CommSize parameter,
> + if not omitted, are in address range that cannot be
> + accessed by the MM environment.
> +
> **/
> typedef
> EFI_STATUS
> (EFIAPI *EFI_MM_COMMUNICATE)(
> IN CONST EFI_MM_COMMUNICATION_PROTOCOL *This,
> IN OUT VOID *CommBuffer,
> - IN OUT UINTN *CommSize
> + IN OUT UINTN *CommSize OPTIONAL
> );
>
> ///
> --
> 2.7.0.windows.1
next prev parent reply other threads:[~2017-12-07 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 9:17 [PATCH 0/2] Follow PI spec to update EFI_MM_COMMUNICATE Star Zeng
2017-12-06 9:17 ` [PATCH 1/2] MdePkg MmCommunication.h: " Star Zeng
2017-12-07 14:59 ` Gao, Liming [this message]
2017-12-06 9:17 ` [PATCH 2/2] MdeModulePkg PiSmmIpl: Handle CommSize OPTIONAL case Star Zeng
2017-12-07 8:07 ` [PATCH 0/2] Follow PI spec to update EFI_MM_COMMUNICATE Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E18C0F3@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox