From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: More than 10 MX records returned) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 353242217CE54 for ; Thu, 7 Dec 2017 06:54:45 -0800 (PST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 06:59:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,373,1508828400"; d="scan'208";a="850314" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 07 Dec 2017 06:59:17 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Dec 2017 06:59:17 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Thu, 7 Dec 2017 22:59:15 +0800 From: "Gao, Liming" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Kinney, Michael D" Thread-Topic: [PATCH 1/2] MdePkg MmCommunication.h: Follow PI spec to update EFI_MM_COMMUNICATE Thread-Index: AQHTbnMnukdSrJjGz0CALKmy+LRi3aM3+u0A Date: Thu, 7 Dec 2017 14:59:14 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E18C0F3@SHSMSX104.ccr.corp.intel.com> References: <1512551879-14388-1-git-send-email-star.zeng@intel.com> <1512551879-14388-2-git-send-email-star.zeng@intel.com> In-Reply-To: <1512551879-14388-2-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/2] MdePkg MmCommunication.h: Follow PI spec to update EFI_MM_COMMUNICATE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 14:54:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, December 6, 2017 5:18 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ;= Gao, Liming ; Kinney, Michael D > > Subject: [PATCH 1/2] MdePkg MmCommunication.h: Follow PI spec to update E= FI_MM_COMMUNICATE >=20 > Follow PI spec (>=3D 1.5) to add new return status code description > and make CommSize OPTIONAL. >=20 > Cc: Jiewen Yao > Cc: Liming Gao > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdePkg/Include/Protocol/MmCommunication.h | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Protocol/MmCommunication.h b/MdePkg/Include/P= rotocol/MmCommunication.h > index 16450e3445b0..774686ba3e7f 100644 > --- a/MdePkg/Include/Protocol/MmCommunication.h > +++ b/MdePkg/Include/Protocol/MmCommunication.h > @@ -55,18 +55,28 @@ typedef struct _EFI_MM_COMMUNICATION_PROTOCOL EFI_MM= _COMMUNICATION_PROTOCOL; >=20 > @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL insta= nce. > @param[in] CommBuffer A pointer to the buffer to convey into = MMRAM. > - @param[in] CommSize The size of the data buffer being passe= d in.On exit, the size of data > + @param[in] CommSize The size of the data buffer being passe= d in. On exit, the size of data > being returned. Zero if the handler doe= s not wish to reply with any data. > + This parameter is optional and may be N= ULL. >=20 > @retval EFI_SUCCESS The message was successfully posted. > @retval EFI_INVALID_PARAMETER The CommBuffer was NULL. > + @retval EFI_BAD_BUFFER_SIZE The buffer is too large for the MM impl= ementation. > + If this error is returned, the MessageL= ength field > + in the CommBuffer header or the integer= pointed by > + CommSize, are updated to reflect the ma= ximum payload > + size the implementation can accommodate= . > + @retval EFI_ACCESS_DENIED The CommunicateBuffer parameter or Comm= Size parameter, > + if not omitted, are in address range th= at cannot be > + accessed by the MM environment. > + > **/ > typedef > EFI_STATUS > (EFIAPI *EFI_MM_COMMUNICATE)( > IN CONST EFI_MM_COMMUNICATION_PROTOCOL *This, > IN OUT VOID *CommBuffer, > - IN OUT UINTN *CommSize > + IN OUT UINTN *CommSize OPTIONAL > ); >=20 > /// > -- > 2.7.0.windows.1