* [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images
@ 2017-12-08 15:55 Ard Biesheuvel
2017-12-08 16:57 ` Leif Lindholm
2017-12-10 13:30 ` Gao, Liming
0 siblings, 2 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2017-12-08 15:55 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, michael.d.kinney, liming.gao, Ard Biesheuvel
The ARM calling convention is fundamentally incompatible with EBC,
and having a cross compatible machine type identical to the native
type does not make a lot of sense either. So restrict the compatible
machine type for ARM to EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, and remove
the cross compatible.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
MdePkg/Include/Uefi/UefiBaseType.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Include/Uefi/UefiBaseType.h b/MdePkg/Include/Uefi/UefiBaseType.h
index 728a0472602a..d9556cd2ec4e 100644
--- a/MdePkg/Include/Uefi/UefiBaseType.h
+++ b/MdePkg/Include/Uefi/UefiBaseType.h
@@ -270,10 +270,9 @@ typedef union {
#elif defined (MDE_CPU_ARM)
-#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \
- (((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) || ((Machine) == EFI_IMAGE_MACHINE_EBC))
+#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
-#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
+#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) (FALSE)
#elif defined (MDE_CPU_AARCH64)
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images
2017-12-08 15:55 [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images Ard Biesheuvel
@ 2017-12-08 16:57 ` Leif Lindholm
2017-12-10 13:30 ` Gao, Liming
1 sibling, 0 replies; 4+ messages in thread
From: Leif Lindholm @ 2017-12-08 16:57 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel, michael.d.kinney, liming.gao
On Fri, Dec 08, 2017 at 03:55:14PM +0000, Ard Biesheuvel wrote:
> The ARM calling convention is fundamentally incompatible with EBC,
> and having a cross compatible machine type identical to the native
> type does not make a lot of sense either. So restrict the compatible
> machine type for ARM to EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, and remove
> the cross compatible.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Looks reasonable.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> MdePkg/Include/Uefi/UefiBaseType.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/MdePkg/Include/Uefi/UefiBaseType.h b/MdePkg/Include/Uefi/UefiBaseType.h
> index 728a0472602a..d9556cd2ec4e 100644
> --- a/MdePkg/Include/Uefi/UefiBaseType.h
> +++ b/MdePkg/Include/Uefi/UefiBaseType.h
> @@ -270,10 +270,9 @@ typedef union {
>
> #elif defined (MDE_CPU_ARM)
>
> -#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \
> - (((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) || ((Machine) == EFI_IMAGE_MACHINE_EBC))
> +#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
>
> -#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
> +#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) (FALSE)
>
> #elif defined (MDE_CPU_AARCH64)
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images
2017-12-08 15:55 [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images Ard Biesheuvel
2017-12-08 16:57 ` Leif Lindholm
@ 2017-12-10 13:30 ` Gao, Liming
2017-12-11 18:05 ` Ard Biesheuvel
1 sibling, 1 reply; 4+ messages in thread
From: Gao, Liming @ 2017-12-10 13:30 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel@lists.01.org
Cc: Kinney, Michael D, leif.lindholm@linaro.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
> Sent: Friday, December 8, 2017 11:55 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; leif.lindholm@linaro.org; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>
> Subject: [edk2] [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images
>
> The ARM calling convention is fundamentally incompatible with EBC,
> and having a cross compatible machine type identical to the native
> type does not make a lot of sense either. So restrict the compatible
> machine type for ARM to EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, and remove
> the cross compatible.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> MdePkg/Include/Uefi/UefiBaseType.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/MdePkg/Include/Uefi/UefiBaseType.h b/MdePkg/Include/Uefi/UefiBaseType.h
> index 728a0472602a..d9556cd2ec4e 100644
> --- a/MdePkg/Include/Uefi/UefiBaseType.h
> +++ b/MdePkg/Include/Uefi/UefiBaseType.h
> @@ -270,10 +270,9 @@ typedef union {
>
> #elif defined (MDE_CPU_ARM)
>
> -#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \
> - (((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) || ((Machine) == EFI_IMAGE_MACHINE_EBC))
> +#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
>
> -#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
> +#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) (FALSE)
>
> #elif defined (MDE_CPU_AARCH64)
>
> --
> 2.11.0
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images
2017-12-10 13:30 ` Gao, Liming
@ 2017-12-11 18:05 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2017-12-11 18:05 UTC (permalink / raw)
To: Gao, Liming
Cc: edk2-devel@lists.01.org, Kinney, Michael D,
leif.lindholm@linaro.org
On 10 December 2017 at 13:30, Gao, Liming <liming.gao@intel.com> wrote:
> Reviewed-by: Liming Gao <liming.gao@intel.com>
>
Thanks. Pushed as 3b3c009a25543bf709267982b2583dd486d4d24d
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
>> Sent: Friday, December 8, 2017 11:55 PM
>> To: edk2-devel@lists.01.org
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; leif.lindholm@linaro.org; Ard Biesheuvel
>> <ard.biesheuvel@linaro.org>
>> Subject: [edk2] [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images
>>
>> The ARM calling convention is fundamentally incompatible with EBC,
>> and having a cross compatible machine type identical to the native
>> type does not make a lot of sense either. So restrict the compatible
>> machine type for ARM to EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, and remove
>> the cross compatible.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> MdePkg/Include/Uefi/UefiBaseType.h | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/MdePkg/Include/Uefi/UefiBaseType.h b/MdePkg/Include/Uefi/UefiBaseType.h
>> index 728a0472602a..d9556cd2ec4e 100644
>> --- a/MdePkg/Include/Uefi/UefiBaseType.h
>> +++ b/MdePkg/Include/Uefi/UefiBaseType.h
>> @@ -270,10 +270,9 @@ typedef union {
>>
>> #elif defined (MDE_CPU_ARM)
>>
>> -#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \
>> - (((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED) || ((Machine) == EFI_IMAGE_MACHINE_EBC))
>> +#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
>>
>> -#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) ((Machine) == EFI_IMAGE_MACHINE_ARMTHUMB_MIXED)
>> +#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) (FALSE)
>>
>> #elif defined (MDE_CPU_AARCH64)
>>
>> --
>> 2.11.0
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-11 18:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-08 15:55 [PATCH] MdePkg/Uefi ARM: only support native ARM/Thumb images Ard Biesheuvel
2017-12-08 16:57 ` Leif Lindholm
2017-12-10 13:30 ` Gao, Liming
2017-12-11 18:05 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox