From: "Gao, Liming" <liming.gao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1 and 2 definitions
Date: Fri, 22 Dec 2017 03:48:45 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E19572A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1513763352-7660-1-git-send-email-star.zeng@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Wednesday, December 20, 2017 5:49 PM
>To: edk2-devel@lists.01.org
>Cc: Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming
><liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1
>and 2 definitions
>
>Same change is done for Acpi61.h.
>
>Cc: Jiewen Yao <jiewen.yao@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Chasel Chiu <chasel.chiu@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> MdePkg/Include/IndustryStandard/Acpi60.h | 48
>+++++++++++++++++++++++++++++++-
> MdePkg/Include/IndustryStandard/Acpi61.h | 48
>+++++++++++++++++++++++++++++++-
> 2 files changed, 94 insertions(+), 2 deletions(-)
>
>diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h
>b/MdePkg/Include/IndustryStandard/Acpi60.h
>index 6183d8a9bd6c..29c16f48405d 100644
>--- a/MdePkg/Include/IndustryStandard/Acpi60.h
>+++ b/MdePkg/Include/IndustryStandard/Acpi60.h
>@@ -2020,7 +2020,9 @@ typedef struct {
> //
> // PCCT Subspace type
> //
>-#define EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_GENERIC 0x00
>+#define EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_GENERIC 0x00
>+#define
>EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_1_HW_REDUCED_COMMUNICATIONS
>0x01
>+#define
>EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_2_HW_REDUCED_COMMUNICATIONS
>0x02
>
> ///
> /// PCC Subspace Structure Header
>@@ -2072,6 +2074,50 @@ typedef struct {
> EFI_ACPI_6_0_PCCT_GENERIC_SHARED_MEMORY_REGION_STATUS
>Status;
> } EFI_ACPI_6_0_PCCT_GENERIC_SHARED_MEMORY_REGION_HEADER;
>
>+#define
>EFI_ACPI_6_0_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_POLARITY
>BIT0
>+#define
>EFI_ACPI_6_0_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_MODE
>BIT1
>+
>+///
>+/// Type 1 HW-Reduced Communications Subspace Structure
>+///
>+typedef struct {
>+ UINT8 Type;
>+ UINT8 Length;
>+ UINT32 DoorbellInterrupt;
>+ UINT8 DoorbellInterruptFlags;
>+ UINT8 Reserved;
>+ UINT64 BaseAddress;
>+ UINT64 AddressLength;
>+ EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellRegister;
>+ UINT64 DoorbellPreserve;
>+ UINT64 DoorbellWrite;
>+ UINT32 NominalLatency;
>+ UINT32 MaximumPeriodicAccessRate;
>+ UINT16 MinimumRequestTurnaroundTime;
>+} EFI_ACPI_6_0_PCCT_SUBSPACE_1_HW_REDUCED_COMMUNICATIONS;
>+
>+///
>+/// Type 2 HW-Reduced Communications Subspace Structure
>+///
>+typedef struct {
>+ UINT8 Type;
>+ UINT8 Length;
>+ UINT32 DoorbellInterrupt;
>+ UINT8 DoorbellInterruptFlags;
>+ UINT8 Reserved;
>+ UINT64 BaseAddress;
>+ UINT64 AddressLength;
>+ EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellRegister;
>+ UINT64 DoorbellPreserve;
>+ UINT64 DoorbellWrite;
>+ UINT32 NominalLatency;
>+ UINT32 MaximumPeriodicAccessRate;
>+ UINT16 MinimumRequestTurnaroundTime;
>+ EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellAckRegister;
>+ UINT64 DoorbellAckPreserve;
>+ UINT64 DoorbellAckWrite;
>+} EFI_ACPI_6_0_PCCT_SUBSPACE_2_HW_REDUCED_COMMUNICATIONS;
>+
> //
> // Known table signatures
> //
>diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h
>b/MdePkg/Include/IndustryStandard/Acpi61.h
>index 0fac9a80694d..4a370c27e012 100644
>--- a/MdePkg/Include/IndustryStandard/Acpi61.h
>+++ b/MdePkg/Include/IndustryStandard/Acpi61.h
>@@ -2052,7 +2052,9 @@ typedef struct {
> //
> // PCCT Subspace type
> //
>-#define EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_GENERIC 0x00
>+#define EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_GENERIC 0x00
>+#define
>EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_1_HW_REDUCED_COMMUNICATIONS
>0x01
>+#define
>EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_2_HW_REDUCED_COMMUNICATIONS
>0x02
>
> ///
> /// PCC Subspace Structure Header
>@@ -2104,6 +2106,50 @@ typedef struct {
> EFI_ACPI_6_1_PCCT_GENERIC_SHARED_MEMORY_REGION_STATUS
>Status;
> } EFI_ACPI_6_1_PCCT_GENERIC_SHARED_MEMORY_REGION_HEADER;
>
>+#define
>EFI_ACPI_6_1_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_POLARITY
>BIT0
>+#define
>EFI_ACPI_6_1_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_MODE
>BIT1
>+
>+///
>+/// Type 1 HW-Reduced Communications Subspace Structure
>+///
>+typedef struct {
>+ UINT8 Type;
>+ UINT8 Length;
>+ UINT32 DoorbellInterrupt;
>+ UINT8 DoorbellInterruptFlags;
>+ UINT8 Reserved;
>+ UINT64 BaseAddress;
>+ UINT64 AddressLength;
>+ EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellRegister;
>+ UINT64 DoorbellPreserve;
>+ UINT64 DoorbellWrite;
>+ UINT32 NominalLatency;
>+ UINT32 MaximumPeriodicAccessRate;
>+ UINT16 MinimumRequestTurnaroundTime;
>+} EFI_ACPI_6_1_PCCT_SUBSPACE_1_HW_REDUCED_COMMUNICATIONS;
>+
>+///
>+/// Type 2 HW-Reduced Communications Subspace Structure
>+///
>+typedef struct {
>+ UINT8 Type;
>+ UINT8 Length;
>+ UINT32 DoorbellInterrupt;
>+ UINT8 DoorbellInterruptFlags;
>+ UINT8 Reserved;
>+ UINT64 BaseAddress;
>+ UINT64 AddressLength;
>+ EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellRegister;
>+ UINT64 DoorbellPreserve;
>+ UINT64 DoorbellWrite;
>+ UINT32 NominalLatency;
>+ UINT32 MaximumPeriodicAccessRate;
>+ UINT16 MinimumRequestTurnaroundTime;
>+ EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellAckRegister;
>+ UINT64 DoorbellAckPreserve;
>+ UINT64 DoorbellAckWrite;
>+} EFI_ACPI_6_1_PCCT_SUBSPACE_2_HW_REDUCED_COMMUNICATIONS;
>+
> //
> // Known table signatures
> //
>--
>2.7.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-12-22 3:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 9:49 [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1 and 2 definitions Star Zeng
2017-12-22 3:48 ` Gao, Liming [this message]
2017-12-22 3:57 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E19572A@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox