public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Liming" <liming.gao@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value
Date: Tue, 26 Dec 2017 08:05:04 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1987D1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B9726D6DCCFB8B4CA276A9169B02216D51F53BE7@SHSMSX103.ccr.corp.intel.com>

Sorry. I will remove it. 

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, December 26, 2017 4:04 PM
>To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Zhu, Yonghong
><yonghong.zhu@intel.com>
>Subject: RE: [Patch] BaseTools: Update SkuId checker to make sure it be valid
>UINT64 value
>
>Please remove the " Signed-off-by" info in Cc.
>
>Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
>
>Best Regards,
>Zhu Yonghong
>
>
>-----Original Message-----
>From: Gao, Liming
>Sent: Tuesday, December 26, 2017 3:59 PM
>To: edk2-devel@lists.01.org
>Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Feng, Bob C
><bob.c.feng@intel.com>
>Subject: [Patch] BaseTools: Update SkuId checker to make sure it be valid
>UINT64 value
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Liming Gao <liming.gao@intel.com>
>Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>Cc: Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/Common/Misc.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/BaseTools/Source/Python/Common/Misc.py
>b/BaseTools/Source/Python/Common/Misc.py
>index 0374be0..f440008 100644
>--- a/BaseTools/Source/Python/Common/Misc.py
>+++ b/BaseTools/Source/Python/Common/Misc.py
>@@ -2149,10 +2149,10 @@ class SkuClass():
>         for SkuName in SkuIds:
>             SkuId = SkuIds[SkuName][0]
>             skuid_num = int(SkuId,16) if SkuId.upper().startswith("0X") else
>int(SkuId)
>-            if skuid_num > 0xFFFF:
>+            if skuid_num > 0xFFFFFFFFFFFFFFFF:
>                 EdkLogger.error("build", PARAMETER_INVALID,
>-                            ExtraData = "SKU-ID [%s] must less than 65535"
>-                                      % (SkuName))
>+                            ExtraData = "SKU-ID [%s] value %s exceeds the max value of
>UINT64"
>+                                      % (SkuName, SkuId))
>
>         self.AvailableSkuIds = sdict()
>         self.SkuIdSet = []
>--
>2.8.0.windows.1



      reply	other threads:[~2017-12-26  8:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-26  7:59 [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value Liming Gao
2017-12-26  8:04 ` Zhu, Yonghong
2017-12-26  8:05   ` Gao, Liming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E1987D1@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox