From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5D2EF21CB87AF for ; Tue, 26 Dec 2017 00:00:39 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Dec 2017 00:05:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,459,1508828400"; d="scan'208";a="18968905" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 26 Dec 2017 00:05:32 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Dec 2017 00:05:06 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Dec 2017 00:05:06 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Tue, 26 Dec 2017 16:05:05 +0800 From: "Gao, Liming" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value Thread-Index: AQHTfiAknnGcSfB2z0m+kabY1dquj6NVRCfA Date: Tue, 26 Dec 2017 08:05:04 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1987D1@SHSMSX104.ccr.corp.intel.com> References: <1514275149-10652-1-git-send-email-liming.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Dec 2017 08:00:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry. I will remove it.=20 >-----Original Message----- >From: Zhu, Yonghong >Sent: Tuesday, December 26, 2017 4:04 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Feng, Bob C ; Zhu, Yonghong > >Subject: RE: [Patch] BaseTools: Update SkuId checker to make sure it be va= lid >UINT64 value > >Please remove the " Signed-off-by" info in Cc. > >Reviewed-by: Yonghong Zhu > >Best Regards, >Zhu Yonghong > > >-----Original Message----- >From: Gao, Liming >Sent: Tuesday, December 26, 2017 3:59 PM >To: edk2-devel@lists.01.org >Cc: Zhu, Yonghong ; Feng, Bob C > >Subject: [Patch] BaseTools: Update SkuId checker to make sure it be valid >UINT64 value > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Liming Gao >Cc: Yonghong Zhu >Cc: Signed-off-by: Bob Feng >--- > BaseTools/Source/Python/Common/Misc.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/BaseTools/Source/Python/Common/Misc.py >b/BaseTools/Source/Python/Common/Misc.py >index 0374be0..f440008 100644 >--- a/BaseTools/Source/Python/Common/Misc.py >+++ b/BaseTools/Source/Python/Common/Misc.py >@@ -2149,10 +2149,10 @@ class SkuClass(): > for SkuName in SkuIds: > SkuId =3D SkuIds[SkuName][0] > skuid_num =3D int(SkuId,16) if SkuId.upper().startswith("0X")= else >int(SkuId) >- if skuid_num > 0xFFFF: >+ if skuid_num > 0xFFFFFFFFFFFFFFFF: > EdkLogger.error("build", PARAMETER_INVALID, >- ExtraData =3D "SKU-ID [%s] must less than 655= 35" >- % (SkuName)) >+ ExtraData =3D "SKU-ID [%s] value %s exceeds t= he max value of >UINT64" >+ % (SkuName, SkuId)) > > self.AvailableSkuIds =3D sdict() > self.SkuIdSet =3D [] >-- >2.8.0.windows.1