* [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value @ 2017-12-26 7:59 Liming Gao 2017-12-26 8:04 ` Zhu, Yonghong 0 siblings, 1 reply; 3+ messages in thread From: Liming Gao @ 2017-12-26 7:59 UTC (permalink / raw) To: edk2-devel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Yonghong Zhu <yonghong.zhu@intel.com> Cc: Signed-off-by: Bob Feng <bob.c.feng@intel.com> --- BaseTools/Source/Python/Common/Misc.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py index 0374be0..f440008 100644 --- a/BaseTools/Source/Python/Common/Misc.py +++ b/BaseTools/Source/Python/Common/Misc.py @@ -2149,10 +2149,10 @@ class SkuClass(): for SkuName in SkuIds: SkuId = SkuIds[SkuName][0] skuid_num = int(SkuId,16) if SkuId.upper().startswith("0X") else int(SkuId) - if skuid_num > 0xFFFF: + if skuid_num > 0xFFFFFFFFFFFFFFFF: EdkLogger.error("build", PARAMETER_INVALID, - ExtraData = "SKU-ID [%s] must less than 65535" - % (SkuName)) + ExtraData = "SKU-ID [%s] value %s exceeds the max value of UINT64" + % (SkuName, SkuId)) self.AvailableSkuIds = sdict() self.SkuIdSet = [] -- 2.8.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value 2017-12-26 7:59 [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value Liming Gao @ 2017-12-26 8:04 ` Zhu, Yonghong 2017-12-26 8:05 ` Gao, Liming 0 siblings, 1 reply; 3+ messages in thread From: Zhu, Yonghong @ 2017-12-26 8:04 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org Please remove the " Signed-off-by" info in Cc. Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> Best Regards, Zhu Yonghong -----Original Message----- From: Gao, Liming Sent: Tuesday, December 26, 2017 3:59 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Feng, Bob C <bob.c.feng@intel.com> Subject: [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Yonghong Zhu <yonghong.zhu@intel.com> Cc: Signed-off-by: Bob Feng <bob.c.feng@intel.com> --- BaseTools/Source/Python/Common/Misc.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py index 0374be0..f440008 100644 --- a/BaseTools/Source/Python/Common/Misc.py +++ b/BaseTools/Source/Python/Common/Misc.py @@ -2149,10 +2149,10 @@ class SkuClass(): for SkuName in SkuIds: SkuId = SkuIds[SkuName][0] skuid_num = int(SkuId,16) if SkuId.upper().startswith("0X") else int(SkuId) - if skuid_num > 0xFFFF: + if skuid_num > 0xFFFFFFFFFFFFFFFF: EdkLogger.error("build", PARAMETER_INVALID, - ExtraData = "SKU-ID [%s] must less than 65535" - % (SkuName)) + ExtraData = "SKU-ID [%s] value %s exceeds the max value of UINT64" + % (SkuName, SkuId)) self.AvailableSkuIds = sdict() self.SkuIdSet = [] -- 2.8.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value 2017-12-26 8:04 ` Zhu, Yonghong @ 2017-12-26 8:05 ` Gao, Liming 0 siblings, 0 replies; 3+ messages in thread From: Gao, Liming @ 2017-12-26 8:05 UTC (permalink / raw) To: Zhu, Yonghong, edk2-devel@lists.01.org Sorry. I will remove it. >-----Original Message----- >From: Zhu, Yonghong >Sent: Tuesday, December 26, 2017 4:04 PM >To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org >Cc: Feng, Bob C <bob.c.feng@intel.com>; Zhu, Yonghong ><yonghong.zhu@intel.com> >Subject: RE: [Patch] BaseTools: Update SkuId checker to make sure it be valid >UINT64 value > >Please remove the " Signed-off-by" info in Cc. > >Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> > >Best Regards, >Zhu Yonghong > > >-----Original Message----- >From: Gao, Liming >Sent: Tuesday, December 26, 2017 3:59 PM >To: edk2-devel@lists.01.org >Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Feng, Bob C ><bob.c.feng@intel.com> >Subject: [Patch] BaseTools: Update SkuId checker to make sure it be valid >UINT64 value > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Liming Gao <liming.gao@intel.com> >Cc: Yonghong Zhu <yonghong.zhu@intel.com> >Cc: Signed-off-by: Bob Feng <bob.c.feng@intel.com> >--- > BaseTools/Source/Python/Common/Misc.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/BaseTools/Source/Python/Common/Misc.py >b/BaseTools/Source/Python/Common/Misc.py >index 0374be0..f440008 100644 >--- a/BaseTools/Source/Python/Common/Misc.py >+++ b/BaseTools/Source/Python/Common/Misc.py >@@ -2149,10 +2149,10 @@ class SkuClass(): > for SkuName in SkuIds: > SkuId = SkuIds[SkuName][0] > skuid_num = int(SkuId,16) if SkuId.upper().startswith("0X") else >int(SkuId) >- if skuid_num > 0xFFFF: >+ if skuid_num > 0xFFFFFFFFFFFFFFFF: > EdkLogger.error("build", PARAMETER_INVALID, >- ExtraData = "SKU-ID [%s] must less than 65535" >- % (SkuName)) >+ ExtraData = "SKU-ID [%s] value %s exceeds the max value of >UINT64" >+ % (SkuName, SkuId)) > > self.AvailableSkuIds = sdict() > self.SkuIdSet = [] >-- >2.8.0.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-26 8:00 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-12-26 7:59 [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value Liming Gao 2017-12-26 8:04 ` Zhu, Yonghong 2017-12-26 8:05 ` Gao, Liming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox