From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4D25522280C23 for ; Wed, 27 Dec 2017 01:24:28 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2017 01:29:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,464,1508828400"; d="scan'208";a="19221420" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 27 Dec 2017 01:29:22 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Dec 2017 01:29:22 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Dec 2017 01:29:22 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Wed, 27 Dec 2017 17:29:20 +0800 From: "Gao, Liming" To: "Wang, Jian J" , "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 0/4] Coding style clean-up Thread-Index: AQHTfRy6CuHyxAfZaUiCYke9EEruhKNVUjYAgACD7wCAARm3kA== Date: Wed, 27 Dec 2017 09:29:19 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E19941F@SHSMSX104.ccr.corp.intel.com> References: <20171225010659.13428-1-jian.j.wang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/4] Coding style clean-up X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 09:24:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jian: I prefer to roll back this change. So, the definition in BaseLib.h can be= kept in the same style.=20 Thanks Liming >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Wang, Jian J >Sent: Wednesday, December 27, 2017 8:40 AM >To: Kinney, Michael D ; edk2- >devel@lists.01.org >Subject: Re: [edk2] [PATCH 0/4] Coding style clean-up > >Hi Mike, > >Since this patch has been checked in trunk, do you think it should be reve= rted? >In addition, instead of using exception list for the ECC tool, I think it'= d be >better >to update ECC tool to use keyword match to check if a field name is public >spec >defined one. Otherwise, if there's new structure type using those field na= mes, >the tool will still report errors. > >Regards, >Jian > >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Wednesday, December 27, 2017 12:48 AM >> To: Wang, Jian J ; edk2-devel@lists.01.org; Kinne= y, >> Michael D >> Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up >> >> Jian, >> >> I do not think this change should be made. >> >> One of the exceptions for not following the >> EDK II code style is if the field names are >> defined in a public specification. In this case >> these fields are all listed in a structure in >> the Intel 64 and IA-32 Architectures Software >> Development Manual, Section 7.2.1, Figure 7-2 >> using upper case register names. >> >> Thanks, >> >> Mike >> >> >> >> > -----Original Message----- >> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] >> > On Behalf Of Jian J Wang >> > Sent: Sunday, December 24, 2017 5:07 PM >> > To: edk2-devel@lists.01.org >> > Subject: [edk2] [PATCH 0/4] Coding style clean-up >> > >> > This patch series are meant for cleaning up code >> > according to coding style >> > requirements. >> > >> > Jian J Wang (4): >> > MdePkg/BaseLib.h: Coding style clean-up >> > MdeModulePkg/Core: Coding style clean-up >> > UefiCpuPkg/UefiCpuPkg.uni: Add missing string >> > definition for new PCDs >> > UefiCpuPkg: Update code to use new structure field >> > names >> > >> > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 >> > ++ >> > MdePkg/Include/Library/BaseLib.h | 72 >> > +++++++++++----------- >> > .../Ia32/ArchExceptionHandler.c | 24 >> > ++++---- >> > .../X64/ArchExceptionHandler.c | 6 >> > +- >> > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 >> > +- >> > UefiCpuPkg/UefiCpuPkg.uni | 16 >> > ++++- >> > 6 files changed, 71 insertions(+), 54 deletions(-) >> > >> > -- >> > 2.15.1.windows.2 >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > edk2-devel@lists.01.org >> > https://lists.01.org/mailman/listinfo/edk2-devel >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel