From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A939521CB87A9 for ; Wed, 27 Dec 2017 18:38:42 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2017 18:43:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,468,1508828400"; d="scan'208";a="5681186" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 27 Dec 2017 18:43:38 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Dec 2017 18:43:37 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Dec 2017 18:43:37 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Thu, 28 Dec 2017 10:43:36 +0800 From: "Gao, Liming" To: "Wang, Jian J" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2 0/2] Fix error in PrintLib Thread-Index: AQHTf4UDxgKhYCGHfkWwZePouE8QwqNYDEFA Date: Thu, 28 Dec 2017 02:43:35 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E199B2F@SHSMSX104.ccr.corp.intel.com> References: <20171228023828.18752-1-jian.j.wang@intel.com> In-Reply-To: <20171228023828.18752-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/2] Fix error in PrintLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 02:38:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= an J Wang > Sent: Thursday, December 28, 2017 10:38 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 0/2] Fix error in PrintLib >=20 > > v2: > > a. Correct incorrect description in commit log > > b. Fix another similar issue in the same function > > c. Fix similar issues in MdeModulePkg/DxePrintLibPrint2Protocol >=20 > Due to a potential hole in the stop condition of the loop, the two contin= uous > access to ArgumentString (index, index+1) inside the loop might cause the > string ending character ('\0') and the byte after it to be read. >=20 > Jian J Wang (2): > MdePkg/BasePrintLib: Fix error in Precision position calculation > MdeModulePkg/DxePrintLibPrint2Protocol: Fix potential string over read >=20 > MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c | 7 +++++-- > MdePkg/Library/BasePrintLib/PrintLibInternal.c | 7 +++++-- > 2 files changed, 10 insertions(+), 4 deletions(-) >=20 > -- > 2.15.1.windows.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel