[PATCH v2] BaseTools/PcdValueCommon: Fix build with XCODE5

[PATCH v2] BaseTools/PcdValueCommon: Fix build with XCODE5

[Alex James]

Use the correct UINT64 format specifier when building on macOS. This is
needed to fix building with XCODE5.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Alex James <theracermaster@gmail.com>
---

Notes:
    v2:
    - Change ifdef to fix GCC build failure [Liming]

 BaseTools/Source/C/Common/PcdValueCommon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Source/C/Common/PcdValueCommon.c
index 6ca0994744..1b7b48c125 100644
--- a/BaseTools/Source/C/Common/PcdValueCommon.c
+++ b/BaseTools/Source/C/Common/PcdValueCommon.c
@@ -266,7 +266,7 @@ Returns:
     sprintf(PcdList[Index].Value, "0x%08x", (UINT32)(Value & 0xffffffff));
     break;
   case PcdDataTypeUint64:
-#ifdef __GNUC__
+#if defined(__GNUC__) && !defined(__APPLE__)
     sprintf(PcdList[Index].Value, "0x%016lx", Value);
 #else
     sprintf(PcdList[Index].Value, "0x%016llx", Value);
-- 
2.15.1

Re: [PATCH v2] BaseTools/PcdValueCommon: Fix build with XCODE5

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Alex James
> Sent: Friday, December 29, 2017 11:00 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2] BaseTools/PcdValueCommon: Fix build with XCODE5
> 
> Use the correct UINT64 format specifier when building on macOS. This is
> needed to fix building with XCODE5.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Alex James <theracermaster@gmail.com>
> ---
> 
> Notes:
>     v2:
>     - Change ifdef to fix GCC build failure [Liming]
> 
>  BaseTools/Source/C/Common/PcdValueCommon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Source/C/Common/PcdValueCommon.c
> index 6ca0994744..1b7b48c125 100644
> --- a/BaseTools/Source/C/Common/PcdValueCommon.c
> +++ b/BaseTools/Source/C/Common/PcdValueCommon.c
> @@ -266,7 +266,7 @@ Returns:
>      sprintf(PcdList[Index].Value, "0x%08x", (UINT32)(Value & 0xffffffff));
>      break;
>    case PcdDataTypeUint64:
> -#ifdef __GNUC__
> +#if defined(__GNUC__) && !defined(__APPLE__)
>      sprintf(PcdList[Index].Value, "0x%016lx", Value);
>  #else
>      sprintf(PcdList[Index].Value, "0x%016llx", Value);
> --
> 2.15.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel