From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=liming.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 94CDB2034B42E for ; Fri, 29 Dec 2017 07:03:16 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Dec 2017 07:08:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,475,1508828400"; d="scan'208";a="16435356" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 29 Dec 2017 07:08:13 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Dec 2017 07:08:13 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Dec 2017 07:08:13 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Fri, 29 Dec 2017 23:08:11 +0800 From: "Gao, Liming" To: Alex James , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2] BaseTools/PcdValueCommon: Fix build with XCODE5 Thread-Index: AQHTgFEkRifDKhw7Ik2k5rB/hXwhJaNabQVw Date: Fri, 29 Dec 2017 15:08:10 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E19B30E@SHSMSX104.ccr.corp.intel.com> References: <3e0c832e5b7d71fd76ec84da996042857d6d9f2a.1514515803.git.theracermaster@gmail.com> In-Reply-To: <3e0c832e5b7d71fd76ec84da996042857d6d9f2a.1514515803.git.theracermaster@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] BaseTools/PcdValueCommon: Fix build with XCODE5 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Dec 2017 15:03:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Al= ex James > Sent: Friday, December 29, 2017 11:00 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] BaseTools/PcdValueCommon: Fix build with XCODE= 5 >=20 > Use the correct UINT64 format specifier when building on macOS. This is > needed to fix building with XCODE5. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alex James > --- >=20 > Notes: > v2: > - Change ifdef to fix GCC build failure [Liming] >=20 > BaseTools/Source/C/Common/PcdValueCommon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Sourc= e/C/Common/PcdValueCommon.c > index 6ca0994744..1b7b48c125 100644 > --- a/BaseTools/Source/C/Common/PcdValueCommon.c > +++ b/BaseTools/Source/C/Common/PcdValueCommon.c > @@ -266,7 +266,7 @@ Returns: > sprintf(PcdList[Index].Value, "0x%08x", (UINT32)(Value & 0xffffffff)= ); > break; > case PcdDataTypeUint64: > -#ifdef __GNUC__ > +#if defined(__GNUC__) && !defined(__APPLE__) > sprintf(PcdList[Index].Value, "0x%016lx", Value); > #else > sprintf(PcdList[Index].Value, "0x%016llx", Value); > -- > 2.15.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel